Fix/issue 3887 button types#3904
Open
pradeep0153 wants to merge 24 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3887.
Description
This PR resolves a semantic HTML issue that frequently leads to unpredictable interface behavior by ensuring all standalone
<button>tags specify an explicittypeattribute.Changes Made
<button>elements missing atypedeclaration.type="button"to buttons that are strictly meant for triggering JavaScript interactions (like opening modals, toggling menus, or expanding accordions) rather than submitting forms.Impact
<button>element rendered inside a<form>without a specified type defaults totype="submit". By explicitly settingtype="button", we eliminate the risk of accidental page reloads or unintended, premature form submissions when a user clicks a secondary action like "Cancel" or "Close".