Matugen theme, responsive layout, search icon mask-image fix, and QoL improvements#56
Matugen theme, responsive layout, search icon mask-image fix, and QoL improvements#56mj0x0 wants to merge 15 commits into
Conversation
feature: add new theme (matugen) and update existing components refactor: make accordion group aware and update settings handler
…ng it to be used by any theme that opts in
|
Hey @mj0x0! However, I see a few issues with the changes and don't think most of them are changes I want to merge in this repository.
If you still want to contribute some of your changes, I think the search engine cycling is a good idea! If you do so, please make sure to not delete the eslint setup, satisfy the linter rules as configured, don't change code that is unrelated and keep the commit history clean. I also won't merge any changes to dependencies in package.json / package-lock.json right now. |
|
Fair enough. The eslint removal was an oversight on my end, not intentional. I'll restore it. The accordion lines were actually an intentional design choice on my part, but I get that it doesn't match how you want it to look, so I'm fine leaving that out of any future PR. I'll close this PR and open isolated, single-purpose PRs instead, starting with the search engine cycling. I'm accepting what you said about the ML images, I'll keep those in my fork. Besides the search engine cycling, there were a couple of other additions in there I did not commit yet, like a clock/greeting (evening, morning) widget and an expand/collapse-all toggle for the accordions. Both are purely local (no server, no external calls), so I think they fit the "standalone" constraint, but wanted to get your gut reaction before I put together isolated PRs for them. |
Can you send a screenshot of how it looks like? But generally, if it fits the design and if you can add a toggle in the settings to show / hide it, sounds good to me. :)
Can you send a video of this to show the behavior? I am wondering if this is necessary as the current implementation only allows having exactly one of the items open. Or would you also change this to have multiple open at the same time? |
Screencast_20260717_095418.webmThe clock is pretty simple. Uses the theme's accent/default colors, and I kept it low opacity. The Expand/collapse-all doesn't change the default model, exactly one accordion stays open as before. The button is additive, it fans all groups open at once, and clicking any accordion collapses it back to just that one. |
14 commits, demo video below. Happy to split into separate PRs if preferred.
What's in here:
recording_small.mp4