Feature/pskip multiple fields#63
Open
mgyoo86 wants to merge 4 commits into
Open
Conversation
Collaborator
Collaborator
Author
|
@bclyons12 This will ensure that the preconditioner is updated at the first time step (when ntime=1). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended the use of "pskip" (number of time steps between preconditioner updates) to multiple fields in time_step_split.f90:
s2_mat (Advancing Fields)
s8_mat (Advancing Density)
s9_mat (Advancing Pressure or Temperature)
s15_mat (Advancing runaway)
Avoiding frequent updates of preconditioners, which are very expensive,
the field solver's performance is greatly enhanced by a factor of 3 to 10.
The "pskip" value can be set in C1_input file, which is fixed during the simulation.
In the future, a more adaptive "pskip" determination could be implemented for better performance and stability of the simulation.
It is encouraged to use this pskip with the "initial_guess" feature to reduce the number of iterations in the field solver.