Skip to content

Issue 1810 - Attenuation IO / Alternative 3#1996

Open
lsawade wants to merge 1 commit into
develfrom
issue-1810-alt-2
Open

Issue 1810 - Attenuation IO / Alternative 3#1996
lsawade wants to merge 1 commit into
develfrom
issue-1810-alt-2

Conversation

@lsawade

@lsawade lsawade commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Description

Alternative 2 for the attenuation IO this does not have tests yet. will add when approved

Issue Number

Close #1810

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
  • I have added labels to the PR (see right hand side of the PR page)
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@lsawade
lsawade requested review from Rohit-Kakodkar and icui July 17, 2026 09:11
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 29.09761% with 385 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.29%. Comparing base (a963913) to head (b7e0329).

Files with missing lines Patch % Lines
core/specfem/io/property/writer.tpp 28.75% 112 Missing and 2 partials ⚠️
...mpl/attenuation_medium/dim3/constant_isotropic.tpp 12.63% 83 Missing ⚠️
...mpl/attenuation_medium/dim2/constant_isotropic.tpp 11.36% 78 Missing ⚠️
core/specfem/io/property/reader.tpp 42.39% 52 Missing and 1 partial ⚠️
core/specfem/io/property/impl/coordinates.hpp 35.13% 21 Missing and 3 partials ⚠️
core/specfem/io/property/impl/sub_block.hpp 65.00% 14 Missing ⚠️
.../specfem/assembly/attenuation/dim2/attenuation.hpp 0.00% 5 Missing ⚠️
.../specfem/assembly/attenuation/dim3/attenuation.hpp 0.00% 5 Missing ⚠️
core/specfem/tag_dispatch/storage.hpp 50.00% 5 Missing ⚠️
core/specfem/assembly/assembly/dim2/assembly.cpp 0.00% 1 Missing and 1 partial ⚠️
... and 1 more

❌ Your patch status has failed because the patch coverage (29.09%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1996      +/-   ##
==========================================
- Coverage   66.32%   65.29%   -1.03%     
==========================================
  Files         589      591       +2     
  Lines       25809    26332     +523     
  Branches     2959     3026      +67     
==========================================
+ Hits        17117    17194      +77     
- Misses       7579     8021     +442     
- Partials     1113     1117       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants