Skip to content

Update Kokkos to release candidate#1999

Merged
lsawade merged 1 commit into
develfrom
kokkos-5-2-0
Jul 22, 2026
Merged

Update Kokkos to release candidate#1999
lsawade merged 1 commit into
develfrom
kokkos-5-2-0

Conversation

@Rohit-Kakodkar

Copy link
Copy Markdown
Collaborator

Description

Please describe the changes/features in this pull request.

No regression on nightly benchmarks.

Issue Number

If there is an issue created for these changes, link it here

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • THE DOCUMENTATION BUILDS WITHOUT WARNINGS/ERRORS
  • I have added labels to the PR (see right hand side of the PR page)
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CMake-based FetchContent configuration for the Kokkos dependency so the project pulls from the Kokkos 5.2.0 release-candidate ref rather than a specific commit SHA.

Changes:

  • Switch Kokkos FetchContent ref from a pinned commit SHA to release-candidate-5.2.0.
  • Update the inline comment describing the Kokkos ref being used.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmake/kokkos.cmake
Comment on lines +50 to +51
# Pinned to the Kokkos 5.2.0 release candidate branch
set(KOKKOS_VERSION "release-candidate-5.2.0")
@lsawade
lsawade merged commit 09a1be8 into devel Jul 22, 2026
10 checks passed
@lsawade
lsawade deleted the kokkos-5-2-0 branch July 22, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants