Issue 1977 - Fix L2 norm computation in tests

tests/unit-tests/displacement_tests/Newmark/dim2/newmark_tests.cpp

@@ -354,15 +354,18 @@ TEST_P(Newmark, 2D) {
           }
 
           const auto computed_value = traces(icomp, count, 1);
-          error += std::sqrt((value[icomp] - computed_value) *
-                             (value[icomp] - computed_value));
-          computed_norm += std::sqrt(computed_value * computed_value);
+          const auto difference = value[icomp] - computed_value;
+          error += difference * difference;
+          computed_norm += computed_value * computed_value;
         }
 
         count++;
       }
     }
 
+    error = std::sqrt(error);
+    computed_norm = std::sqrt(computed_norm);
+
     // When the reference norm is zero both the reference and computed
     // seismograms must be zero for the test to pass.
     const bool failed = (computed_norm == 0)

tests/unit-tests/displacement_tests/Newmark/dim3/newmark_tests.cpp

@@ -269,15 +269,18 @@ TEST_P(Newmark, 3D) {
           }
 
           const auto computed_value = traces(icomp, count, 1);
-          error += std::sqrt((value[icomp] - computed_value) *
-                             (value[icomp] - computed_value));
-          computed_norm += std::sqrt(computed_value * computed_value);
+          const auto difference = value[icomp] - computed_value;
+          error += difference * difference;
+          computed_norm += computed_value * computed_value;
         }
 
         count++;
       }
     }
 
+    error = std::sqrt(error);
+    computed_norm = std::sqrt(computed_norm);
+
     // When the reference norm is zero both the reference and computed
     // seismograms must be zero for the test to pass.
     const bool failed = (computed_norm == 0)

tests/unit-tests/displacement_tests/Newmark/mpi/dim3/newmark_tests.cpp

@@ -307,15 +307,18 @@ TEST_P(NewmarkMPI, 3D) {
           }
 
           const auto computed_value = traces(icomp, count, 1);
-          error += std::sqrt((value[icomp] - computed_value) *
-                             (value[icomp] - computed_value));
-          computed_norm += std::sqrt(computed_value * computed_value);
+          const auto difference = value[icomp] - computed_value;
+          error += difference * difference;
+          computed_norm += computed_value * computed_value;
         }
 
         count++;
       }
     }
 
+    error = std::sqrt(error);
+    computed_norm = std::sqrt(computed_norm);
+
     if (error / computed_norm > Test.tolerance ||
         std::isnan(error / computed_norm)) {
       FAIL() << "--------------------------------------------------\n"

tests/unit-tests/displacement_tests/Newmark/serial/dim3/HomogeneousAcousticFreeSurfaceForceSource3D/specfem_config.yaml

@@ -24,7 +24,7 @@ parameters:
         writer:
           seismogram:
             format: ascii
-            directory: "./traces_gen"
+            directory: "./"
 
   receivers:
     stations: "displacement_tests/Newmark/serial/dim3/HomogeneousAcousticFreeSurfaceForceSource3D/STATIONS"