feat: add validation_frequency option to fine-tuning (#811)#816
Open
Anakintano wants to merge 1 commit intoPriorLabs:mainfrom
Open
feat: add validation_frequency option to fine-tuning (#811)#816Anakintano wants to merge 1 commit intoPriorLabs:mainfrom
Anakintano wants to merge 1 commit intoPriorLabs:mainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
|
- Add `validation_frequency: int | None = 1` parameter to `FinetunedTabPFNBase`, `FinetunedTabPFNClassifier`, and `FinetunedTabPFNRegressor` - When `validation_frequency=None`, validation is disabled entirely (also disables early stopping with a UserWarning) - When `validation_frequency=N`, validation runs every N epochs - Default of 1 preserves existing behaviour (validate every epoch) Closes PriorLabs#811
Anakintano
force-pushed
the
fix/issue-811
branch
from
2e99f23 to
6affc25
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a validation_frequency parameter to control validation during fine-tuning. The implementation is well-structured. I've added one comment to suggest validating the new parameter to prevent potential runtime errors. It would also be beneficial to add unit tests for this new functionality to ensure its correctness and prevent regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #811
Summary
validation_frequency: int | None = 1parameter toFinetunedTabPFNBase,FinetunedTabPFNClassifier, andFinetunedTabPFNRegressorvalidation_frequency=None: disables validation entirely (also disables early stopping, emits UserWarning if early_stopping=True)validation_frequency=N: runs validation every N epochsvalidation_frequency=1(default): preserves existing behaviourTest plan