Skip to content

fix: shaky test due to pandas version dependency#819

Merged
alanprior merged 2 commits intomainfrom
alan/fix_unstable_test
Mar 17, 2026
Merged

fix: shaky test due to pandas version dependency#819
alanprior merged 2 commits intomainfrom
alan/fix_unstable_test

Conversation

@alanprior
Copy link
Contributor

@alanprior alanprior commented Mar 17, 2026

Issue

Please link the corresponding GitHub issue. If an issue does not already exist,
please open one to describe the bug or feature request before creating a pull request.

This allows us to discuss the proposal and helps avoid unnecessary work.

Motivation and Context

We are fixing a shaky test that was affected by different behavior of pandas v3.


Public API Changes

  • [X ] No Public API changes
  • Yes, Public API changes (Details below)

How Has This Been Tested?

This is a test fix.


Checklist

  • [ X] The changes have been tested locally.
  • [ X] Documentation has been updated (if the public API or usage changes).
  • [ X] A changelog entry has been added (see changelog/README.md), or "no changelog needed" label requested.
  • [X ] The code follows the project's style guidelines.
  • [ X] I have considered the impact of these changes on the public API.

@alanprior alanprior requested a review from a team as a code owner March 17, 2026 13:15
@alanprior alanprior requested review from jmetzen-pl, noahho and psinger-prior and removed request for a team and noahho March 17, 2026 13:15
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a flaky test caused by a dependency on the pandas version. The change correctly updates the test data to ensure consistent behavior across different pandas versions by accounting for how None and np.nan are handled. The fix is appropriate and the explanatory comment is helpful. I have one suggestion to make the test even more robust.

@alanprior alanprior added no changelog needed PR does not require a changelog entry labels Mar 17, 2026
Copy link

@jmetzen-pl jmetzen-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting this to public (will do the same in the future)!

Copy link
Contributor

@psinger-prior psinger-prior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thx

@alanprior alanprior added this pull request to the merge queue Mar 17, 2026
Merged via the queue into main with commit 512845a Mar 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog needed PR does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants