fix: shaky test due to pandas version dependency#819
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a flaky test caused by a dependency on the pandas version. The change correctly updates the test data to ensure consistent behavior across different pandas versions by accounting for how None and np.nan are handled. The fix is appropriate and the explanatory comment is helpful. I have one suggestion to make the test even more robust.
jmetzen-pl
approved these changes
Mar 17, 2026
jmetzen-pl
left a comment
There was a problem hiding this comment.
Thanks for porting this to public (will do the same in the future)!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Please link the corresponding GitHub issue. If an issue does not already exist,
please open one to describe the bug or feature request before creating a pull request.
This allows us to discuss the proposal and helps avoid unnecessary work.
Motivation and Context
We are fixing a shaky test that was affected by different behavior of pandas v3.
Public API Changes
How Has This Been Tested?
This is a test fix.
Checklist
changelog/README.md), or "no changelog needed" label requested.