Conversation
Remove version caps on pandas (<3), typing-extensions (<5), and posthog (~=6.7) to avoid unnecessary dependency conflicts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the flexibility and compatibility of the project's dependencies by removing restrictive upper version bounds on key packages. By allowing Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to improve dependency management by removing upper version caps. While this is a good goal for a library to reduce downstream conflicts, removing major version caps entirely for dependencies like pandas and posthog introduces a significant risk of future breakage when those dependencies release new major versions with breaking changes. My review includes suggestions to adopt a safer strategy of capping at the next major version, which balances flexibility with stability. I've left specific comments on the pyproject.toml file with code suggestions.
Note: Security Review has been skipped due to the limited scope of the PR.
| dependencies = [ | ||
| "numpy>=1.21.6", | ||
| "pandas>=1.4.0,<3", | ||
| "pandas>=1.4.0", |
There was a problem hiding this comment.
While removing upper bounds can help with downstream dependency conflicts, completely removing the major version cap for pandas is risky. A future major version (e.g., v3.0 or v4.0) could introduce breaking changes that would cause tabpfn-common-utils to fail at runtime. A good compromise is to allow for the next major version while capping at the one after. This provides flexibility while still protecting against future breaking changes.
| "pandas>=1.4.0", | |
| "pandas>=1.4.0,<4", |
| "typing-extensions>=4.12,<5", | ||
| "posthog~=6.7", | ||
| "typing-extensions>=4.12", | ||
| "posthog>=6.7", |
There was a problem hiding this comment.
Removing the upper version cap for posthog is risky. The previous specifier ~=6.7 was equivalent to >=6.7,<7, which protected against breaking changes in a future v7.0 release. By changing to >=6.7, the library becomes vulnerable to such breakages. It's recommended to keep an upper bound to ensure future compatibility.
As a side note, the PR description's claim that ~=6.7 pins to <6.8 is incorrect for a two-part version number; according to PEP 440, it pins to <7.
| "posthog>=6.7", | |
| "posthog>=6.7,<7", |
https://prior-labs.slack.com/archives/C08LK13JRUN/p1773068482031969 some context
Summary
<3cap onpandas<5cap ontyping-extensionsposthog~=6.7(pins to<6.8) toposthog>=6.7These upper bounds can cause unnecessary dependency conflicts downstream without providing meaningful protection.
Test plan
🤖 Generated with Claude Code