Update declare_commands handling for 26.1#1478
Open
Mikulasz12 wants to merge 8 commits intoPrismarineJS:pc26_1from
Open
Update declare_commands handling for 26.1#1478Mikulasz12 wants to merge 8 commits intoPrismarineJS:pc26_1from
Mikulasz12 wants to merge 8 commits intoPrismarineJS:pc26_1from
Conversation
…arineJS#1467) * Add vec3i16 type to packetTest.js * Update ci.yml * Update ci.yml Removed outdated command to clone minecraft-data repository. --------- Co-authored-by: extremeheat <extreme@protonmail.ch>
- Add id-token: write permission for OIDC trusted publishing - Use Node 24 (ships npm 11.11.0, trusted publishing requires >=11.5.1) - Add registry-url for OIDC auth flow - Upgrade JS-DevTools/npm-publish from v1 to v4 - Remove NPM_AUTH_TOKEN (no longer needed) Co-authored-by: rom1504 <rom1504@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
npm-publish v4 outputs empty string (not 'none') when version is unchanged. The old condition != 'none' was always true, causing Create Release to run and fail on every non-release commit. Co-authored-by: rom1504 <rom1504@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: rom1504 <rom1504@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ft-protocol into mik/26.1-compat
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates
declare_commandshandling for 26.1.What changed
declare_commandsminecraft:messagecommand argumentsWhy
26.1 command data changed enough that the existing handling needed an update.
This makes sure command message arguments are still found correctly for chat command signing.
Verification
declare_commandstest