setup(esm): put it as first#53
Conversation
|
I think we should move much less files. Otherwise it will be really bad in bigger packages. |
Why not merge this pr with the proof that CJS works, then do the following which removes the CJS test now on npmjs: unpacked size 34.3 kB |
|
If we have to move so many files then I would say it doesn't work and we shouldn't migrate |
AH you mean moving to mod, src ... ? we can do without bu IMO it's will be better in term of maintainability |
|
Most of the changes here are unnecessary. Simply changing module.export with export keyword should be all that's needed |
The idea of having main mod on ESM is to allowing JSR publish (REF discord discussion) |
|
Unless that doesn't support npm packages, I don't understand the comment |
Could you rephrase your idea because I didn't get it |
|
Can you change this PR so that it modifies the minimal amount of files and moves none ? |
|
I can ofc |
|
looks like this specific module has already been supporting esm since 2021 #17 |
Yes, but no, the idea here is to put the esm first. As a reminder, the ultimate goal is to publish packages on JSR in order to move forward with the JS ecosystem. |
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
|
@rom1504 ready ? |
|
cc @rom1504 |
Note
That's an experiment so it's may not be merged