Open
Conversation
Collaborator
|
Happy to add a configurable StrategyType for the deployment, but I'd like to keep the default in the chart matching the current StrategyType and kubernetes default, |
Author
|
Make sense to me :) |
bdashrad
requested changes
Sep 17, 2025
Co-authored-by: Brad Clark <bdashrad@gmail.com>
Co-authored-by: Brad Clark <bdashrad@gmail.com>
bdashrad
approved these changes
Sep 19, 2025
bdashrad
requested changes
Sep 19, 2025
Collaborator
bdashrad
left a comment
bdashrad
left a comment
There was a problem hiding this comment.
could you add one more change, updating the artifact.io/changes section in the Chart.yaml to
artifacthub.io/changes: |
- kind: added
description: Allow overrriding default deploymentStrategy in values.yaml
links:
- name: Github PR
url: https://github.com/PrivateBin/helm-chart/pull/115
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.