fix: normalize room github usernames#2188
Conversation
|
@nyxsky404 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
|
This PR now has a merge conflict with Please rebase your branch on git fetch origin
git rebase origin/mainOnce the conflicts are resolved and CI passes, we can merge this. |
0f930de to
12ddf84
Compare
12ddf84 to
57f7bda
Compare
|
@Priyanshu-byte-coder The 11 failing Playwright smoke tests are pre-existing failures unrelated to this PR's changes. The failures are in |
Summary
Normalized collaboration room membership to use stable GitHub logins and case-insensitive invite checks.
Closes #2183
Type of Change
Changes Made
session.githubLogininstead ofsession.user.nameloginreturned by the GitHub API when inviting membersHow to Test
Steps for the reviewer to verify this works:
npm run test -- rooms.test.tsOctocatoctocatValidation performed:
npm run test -- rooms.test.tspassesnpm run type-checkcurrently fails on existing project-wide dependency/type issues unrelated to this changenpm run lintcurrently fails before linting because@ducanh2912/next-pwais missing from local module resolutionScreenshots (if UI change)
N/A
Checklist
npm run lintpasses locallynpm run type-check)Accessibility Checklist
Additional Notes
This change intentionally avoids a database migration and fixes the behavior at the API layer. A future migration could add a case-insensitive uniqueness constraint for stronger database-level enforcement.