feat(ux): add loading and disabled states for async action buttons#2204
Open
Antra1705 wants to merge 2 commits into
Open
feat(ux): add loading and disabled states for async action buttons#2204Antra1705 wants to merge 2 commits into
Antra1705 wants to merge 2 commits into
Conversation
|
@Antra1705 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added consistent
disabledand loading states to all action buttons that trigger async API/fetch calls across the codebase, preventing double-submissions and race conditions.Closes #1508
Type of Change
Changes Made
ConfirmModal.tsx: Addeddisabledprop to block Confirm/Cancel buttons and backdrop/Escape dismissal during in-flight operationsProjectMetrics.tsx: Addeddisconnectingstate to Jira Disconnect buttonGoalTracker.tsx: AddedincrementingIdstate to manual +1 button; passeddisabled={deletingId !== null}to ConfirmModal during deletionTodayFocusHero.tsx: AddedisSavingandisClearingstates to Save and Clear buttons, disabling input during flightStreakTracker.tsx: Fixed conditional rendering of freeze block (freeze !== nullinstead of!freezeLoading); added loading state to Freeze/Cancel freeze buttonssettings/page.tsx: Addeddisabled={saving}to Spotlight Pin, Unpin, Move Up, Move Down buttons and search inputRoomClient.tsx: Addeddeletingstate to Delete Room button with "Deleting..." labelHow to Test
Screenshots (if UI change)
Checklist
npm run lintpasses locallynpm run type-check)Accessibility Checklist
Additional Notes
mainbranch after upstream PR fix: split Supabase client into admin and browser modules for security #2114 (Supabase client refactor). Verified viagit stashthat zero failures are introduced by this PR — all failures pre-exist.disabled:opacity-60,disabled:cursor-not-allowed).