fix(a11y): ensure productivity level badge is screen-reader accessible (#952)#2206
Open
mallya-m wants to merge 7 commits into
Open
fix(a11y): ensure productivity level badge is screen-reader accessible (#952)#2206mallya-m wants to merge 7 commits into
mallya-m wants to merge 7 commits into
Conversation
|
@mallya-m is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
…#251) - Add OnboardingTour component using driver.js - Add Take Tour button in DashboardHeader - Extend settings PATCH to accept seen_onboarding field - Tour auto-starts for new users, skips in E2E environments
4672da8 to
cad8a5a
Compare
cad8a5a to
ca89dca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes color-only encoding accessibility violation in
CodingActivityInsightsCardproductivity badge.Closes #952
Type of Change
Changes Made
ariaLabelprop to theInsightRowcomponentaria-label="Productivity level: <Level>"to the productivity badge<p>tag so screen readers announce the level in plain English instead of the emoji nameinsightRowsarray to support the optionalariaLabelfieldHow to Test
<p>element announces"Productivity level: Excellent"(or whichever level applies) — not"large green circle Excellent"Excellent,Good,Moderate, etc.) is always visible regardless of color perceptionScreenshots (if UI change)
N/A — no visual change. The fix is in the accessibility tree only.
Checklist
npm run lintpasses locallynpx tsc --noEmit 2>&1 | Select-String "CodingActivityInsightsCard"→ blank)Accessibility Checklist
aria-labeladded to productivity badge for screen reader supportAdditional Notes
Pre-existing build errors exist in
upstream/mainunrelated to this PR (@/lib/leaderboard,session.errortype mismatch in repos route) — introduced by other open PRs with zero overlap with this change. OnlyCodingActivityInsightsCard.tsxwas modified.