Perf/memoize pinned top repos 1458#2222
Open
Antra1705 wants to merge 3 commits into
Open
Conversation
|
@Antra1705 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refined the custom comparator for the memoized
RepoItemcomponent inTopRepos.tsxto fix missing equality checks that caused stale UI states during real-time SSE sync events.Closes #1458
Type of Change
Changes Made
repo.urlandrepo.descriptionin theRepoItemcomparatorrepo.languagesarray to prevent stale language badgeshealth.signalsto prevent stale health tooltipsareLanguagesEqualandareHealthSignalsEqualto keep comparator logic self-containedHow to Test
npm run devand open the dashboardRepoItemcomponents with unchanged data do not re-renderScreenshots (if UI change)
N/A
Checklist
npm run lintpasses locallynpm run type-check)npm run buildsucceedsAdditional Notes
Core
React.memowrappers forRepoItemandRepoCardwere introduced in PR #1503. This PR refines the comparator logic only — no structural changes to component hierarchy.The failing E2E check (
streak freeze APIine2e/streak.spec.ts:229) is unrelated to this PR's changes, which are scoped toTopRepos.tsxonly. Confirmed pre-existing onmain— caused bysetupStreakMocksreturning an empty contributions object, triggering an early return inStreakTracker.tsxbefore the freeze button renders.