Potential fix for code scanning alert no. 2: Incomplete string escaping or encoding#17
Merged
Conversation
…ng or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ProSoDiAC/prosodiac.github.io/security/code-scanning/2
In general, to fix this kind of problem you should either (a) use a well-tested library for whitespace/indentation normalization, or (b) ensure that your
replacecall uses a global regular expression (with thegflag) so that all intended occurrences are replaced, not just the first.For this specific case in
assets/js/distillpub/template.v2.js, inside theCodeclass’srenderContentmethod, the goal of the “normalize the tab indents” block is to normalize indentation across the entirecontentstring. On line 4246,content.replace(/\n/, "")currently removes only the first newline. The minimal, behavior-preserving fix is to change this tocontent.replace(/\n/g, ""), which removes all newline characters before the code computestabsand performs the subsequent normalization. No other lines, imports, or helper methods are required; the change is purely in the regular expression literal.Concretely:
assets/js/distillpub/template.v2.js, in theif (this.hasAttribute("block")) {block, update thecontent = content.replace(/\n/, "");line to use/\n/ginstead of/\n/.Suggested fixes powered by Copilot Autofix. Review carefully before merging.