Skip to content

Fix multiple bugs : undefined vars, incorrect condition, SSL/TLS config#5

Open
tgrevillot wants to merge 1 commit intoProcessusT:mainfrom
tgrevillot:fix-bot-email-implementation
Open

Fix multiple bugs : undefined vars, incorrect condition, SSL/TLS config#5
tgrevillot wants to merge 1 commit intoProcessusT:mainfrom
tgrevillot:fix-bot-email-implementation

Conversation

@tgrevillot
Copy link
Copy Markdown

@tgrevillot tgrevillot commented Nov 3, 2022

Hey Processus !
I was trying to implement it by myself but I noticed some bugs, here is a quick sum up of problems detected and fixed :

  • Undefined variables in functions : probably a mismatch between arguments name and variables in core content
  • Admin check condition : var type problem, comparison between string and id --> often false.
  • Discord BOT : Send a message "Starting scraping" in the discord channel as this operation could take some times
  • Email configuration : Now supporting email tls and ssl feature. Tested with a mail provider using tls, but not with ssl.

Waiting for your feedback, have a nice day !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant