Fix fan detection on M5 Max (Mac17,6)#2
Open
sammcj wants to merge 1 commit into
Open
Conversation
FNum is absent on some Apple Silicon SKUs (verified on MacBook Pro
M5 Max Mac17,6). fanCount() previously threw readFailed("FNum"),
which broke status, set, max, auto, and the menu bar app's monitor
tick (which calls status() and silently swallows errors).
Fall back to probing F<i>Ac (0..<10) when FNum is missing, returning
the count of present actual-RPM keys. Existing FNum-supporting
hardware is unaffected.
mileadev
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FNum is absent on some Apple Silicon SKUs (verified on MacBook Pro M5 Max Mac17,6). fanCount() previously threw readFailed("FNum"), which broke status, set, max, auto, and the menu bar app's monitor tick (which calls status() and silently swallows errors).
Fall back to probing FAc (0..<10) when FNum is missing, returning the count of present actual-RPM keys. Existing FNum-supporting hardware is unaffected.