Pr/workspace bugs

eslint.config.mjs

@@ -91,6 +91,7 @@ export default defineConfig([
             "src/services/embeddings/IndexingQueue.ts",
             "src/settings/getStartedStatus.ts",
             "src/utils/cli*.ts",
+            "src/database/storage/JSONLWriter.ts",
         ],
         rules: {
             "import/no-nodejs-modules": "off",

src/agents/searchManager/services/MemorySearchProcessor.ts

@@ -450,7 +450,7 @@ export class MemorySearchProcessor implements MemorySearchProcessorInterface {
 
       for (const state of statesResult.items) {
         let score = 0;
-        if (state.name.toLowerCase().includes(queryLower)) score += 0.9;
+        if (state.name?.toLowerCase().includes(queryLower)) score += 0.9;
         if (score > 0) {
           results.push({ trace: state as unknown as RawMemoryResult['trace'], similarity: score } as RawMemoryResult);
         }
@@ -473,7 +473,7 @@ export class MemorySearchProcessor implements MemorySearchProcessorInterface {
 
       for (const workspace of workspaces) {
         let score = 0;
-        if (workspace.name.toLowerCase().includes(queryLower)) score += 0.9;
+        if (workspace.name?.toLowerCase().includes(queryLower)) score += 0.9;
         if (workspace.description?.toLowerCase().includes(queryLower)) score += 0.8;
         if (score > 0) {
           results.push({ trace: workspace as unknown as RawMemoryResult['trace'], similarity: score } as RawMemoryResult);

src/agents/toolManager/services/ToolBatchExecutionService.ts

@@ -237,7 +237,7 @@ export class ToolBatchExecutionService {
     }
 
     const byName = this.knownWorkspaces.find(workspace =>
-      workspace.name.toLowerCase() === workspaceId.toLowerCase()
+      workspace.name?.toLowerCase() === workspaceId.toLowerCase()
     );
     if (byName) {
       return null;

src/components/LLMProviderModal.ts

@@ -12,7 +12,7 @@
  * - GenericProviderModal (API-key providers)
  */
 
-import { Modal, App } from 'obsidian';
+import { Modal, App } from 'obsidian';
 import { LLMProviderConfig } from '../types';
 import { LLMProviderManager } from '../services/llm/providers/ProviderManager';
 import { StaticModelsService } from '../services/StaticModelsService';
@@ -40,7 +40,7 @@ export interface LLMProviderModalConfig {
   config: LLMProviderConfig;
   oauthConfig?: OAuthModalConfig;
   secondaryOAuthProvider?: SecondaryOAuthProviderConfig;
-  onSave: (config: LLMProviderConfig) => void;
+  onSave: (config: LLMProviderConfig) => void | Promise<void>;
   /** If true, hide the API key input — provider uses OAuth exclusively */
   oauthOnly?: boolean;
 }
@@ -168,7 +168,7 @@ export class LLMProviderModal extends Modal {
         clearTimeout(this.autoSaveTimeout);
         this.autoSaveTimeout = null;
       }
-      this.config.onSave(config);
+      void this.config.onSave(config);
       this.showSaveStatus('Saved');
       setTimeout(() => this.showSaveStatus('Ready'), 2000);
     } else {
@@ -187,19 +187,24 @@ export class LLMProviderModal extends Modal {
     this.showSaveStatus('Saving...');
 
     this.autoSaveTimeout = setTimeout(() => {
-      // Get final config from provider modal
-      if (this.providerModal) {
-        this.config.config = this.providerModal.getConfig();
-      }
-
-      // Call the save callback
-      this.config.onSave(this.config.config);
-      this.showSaveStatus('Saved');
-
-      // Reset status after 2 seconds
-      setTimeout(() => {
-        this.showSaveStatus('Ready');
-      }, 2000);
+      void (async () => {
+        // Get final config from provider modal
+        if (this.providerModal) {
+          this.config.config = this.providerModal.getConfig();
+        }
+
+        try {
+          await this.config.onSave(this.config.config);
+          this.showSaveStatus('Saved');
+        } catch {
+          this.showSaveStatus('Save failed');
+        }
+
+        // Reset status after 2 seconds
+        setTimeout(() => {
+          this.showSaveStatus('Ready');
+        }, 2000);
+      })();
     }, 500);
   }
 

src/components/shared/ChatSettingsRenderer.ts

@@ -514,7 +514,7 @@ export class ChatSettingsRenderer {
         dropdown.onChange((value) => {
           this.settings.workspaceId = value || null;
           this.notifyChange();
-          void this.syncWorkspacePrompt(value);
+          this.syncWorkspacePrompt(value);
         });
       });
 

src/core/ingest/VaultIngestionManager.ts

@@ -253,6 +253,7 @@ export class VaultIngestionManager {
       };
     }
 
+
     const transcriptionProvider = llmSettings.defaultTranscriptionModel?.provider;
     const transcriptionModel = llmSettings.defaultTranscriptionModel?.model;
     if (!transcriptionProvider || !transcriptionModel) {

src/database/adapters/HybridStorageAdapter.ts

@@ -56,12 +56,12 @@ import { ConversationRepository } from '../repositories/ConversationRepository';
 import { MessageRepository } from '../repositories/MessageRepository';
 import { ProjectRepository } from '../repositories/ProjectRepository';
 import { TaskRepository } from '../repositories/TaskRepository';
-// Import services
-import { ExportService } from '../services/ExportService';
-
-type ExportServiceStateRepo = {
-  getStates(workspaceId: string, sessionId: string | undefined, options?: { pageSize?: number }): Promise<{ items: StateData[] }>;
-};
+// Import services
+import { ExportService } from '../services/ExportService';
+
+type ExportServiceStateRepo = {
+  getStates(workspaceId: string, sessionId: string | undefined, options?: { pageSize?: number }): Promise<{ items: StateData[] }>;
+};
 
 /**
  * Configuration options for HybridStorageAdapter
@@ -158,16 +158,16 @@ export class HybridStorageAdapter implements IStorageAdapter {
     this.taskRepo = new TaskRepository(deps);
 
     // Initialize services
-    this.exportService = new ExportService({
-      app: this.app,
-      conversationRepo: this.conversationRepo,
-      messageRepo: this.messageRepo,
-      workspaceRepo: this.workspaceRepo,
-      sessionRepo: this.sessionRepo,
-      stateRepo: this.stateRepo as unknown as ExportServiceStateRepo,
-      traceRepo: this.traceRepo
-    });
-  }
+    this.exportService = new ExportService({
+      app: this.app,
+      conversationRepo: this.conversationRepo,
+      messageRepo: this.messageRepo,
+      workspaceRepo: this.workspaceRepo,
+      sessionRepo: this.sessionRepo,
+      stateRepo: this.stateRepo as unknown as ExportServiceStateRepo,
+      traceRepo: this.traceRepo
+    });
+  }
 
   // ============================================================================
   // Lifecycle Management
@@ -199,10 +199,10 @@ export class HybridStorageAdapter implements IStorageAdapter {
     });
 
     // Start initialization in background
-    this.performInitialization().catch((error: unknown) => {
-      this.initError = error instanceof Error ? error : new Error(String(error));
-      console.error('[HybridStorageAdapter] Background initialization failed:', error);
-    });
+    this.performInitialization().catch((error: unknown) => {
+      this.initError = error instanceof Error ? error : new Error(String(error));
+      console.error('[HybridStorageAdapter] Background initialization failed:', error);
+    });
 
     // If blocking mode, wait for completion
     if (blocking) {
@@ -248,6 +248,23 @@ export class HybridStorageAdapter implements IStorageAdapter {
       // This can take a long time for large vaults (168MB+ JSONL files).
       // The UI will show incrementally as data syncs in.
       const syncState = await this.sqliteCache.getSyncState(this.jsonlWriter.getDeviceId());
+
+      // 5. Prune orphaned conversation JSONL files BEFORE sync/rebuild.
+      // Only safe when a prior session exists (syncState present), meaning SQLite
+      // accurately reflects what was alive at end of last session. Orphaned files
+      // (from the pre-fix delete bug) have no SQLite record at this point and can
+      // be safely deleted. Running BEFORE rebuild prevents fullRebuild from
+      // re-reading the orphaned files and resurrecting deleted conversations.
+      // Skip on first-ever startup (!syncState) — SQLite is empty and every file
+      // would look orphaned.
+      if (syncState) {
+        try {
+          await this.pruneOrphanedConversationFiles();
+        } catch (pruneError) {
+          console.error('[HybridStorageAdapter] Orphaned conversation file pruning failed:', pruneError);
+        }
+      }
+
       if (!syncState || actuallyMigrated) {
         try {
           await this.syncCoordinator.fullRebuild();
@@ -261,14 +278,14 @@ export class HybridStorageAdapter implements IStorageAdapter {
           console.error('[HybridStorageAdapter] Incremental sync failed:', syncError);
         }
 
-        // 5. Reconcile JSONL workspaces missing from SQLite
+        // 6. Reconcile JSONL workspaces missing from SQLite
         try {
           await this.reconcileMissingWorkspaces();
         } catch (reconcileError) {
           console.error('[HybridStorageAdapter] Workspace reconciliation failed:', reconcileError);
         }
 
-        // 6. Reconcile JSONL tasks missing from SQLite
+        // 7. Reconcile JSONL tasks missing from SQLite
         try {
           await this.reconcileMissingTasks();
         } catch (reconcileError) {
@@ -390,6 +407,40 @@ export class HybridStorageAdapter implements IStorageAdapter {
     }
   }
 
+  /**
+   * Remove JSONL files for conversations that no longer exist in SQLite.
+   *
+   * Prior to the deleteConversation fix, ConversationRepository.delete() only
+   * removed the SQLite row and never deleted the JSONL file. This left orphaned
+   * files behind for every conversation that was ever deleted. This method runs
+   * once per startup (incremental sync path) to clean them up.
+   */
+  private async pruneOrphanedConversationFiles(): Promise<void> {
+    const files = await this.jsonlWriter.listFiles('conversations');
+    if (files.length === 0) return;
+
+    let pruned = 0;
+    for (const file of files) {
+      const match = file.match(/conversations\/conv_(.+)\.jsonl$/);
+      if (!match) continue;
+
+      const conversationId = match[1];
+      const existing = await this.conversationRepo.getById(conversationId);
+      if (existing) continue;
+
+      try {
+        await this.jsonlWriter.deleteFile(file);
+        pruned++;
+      } catch (e) {
+        console.error(`[HybridStorageAdapter] Failed to prune orphaned conversation file ${file}:`, e);
+      }
+    }
+
+    if (pruned > 0) {
+      console.warn(`[HybridStorageAdapter] Pruned ${pruned} orphaned conversation JSONL file(s)`);
+    }
+  }
+
   /**
    * Check if the adapter is ready for use
    */