docs: audit PR #104 and #105 from Midway65#106
Merged
Conversation
Both PRs carry the full PR #97 payload (previously partially rejected) with workspace optimization commits stacked on top. The new workspace work (two-tier prompt, cheap restore, dead fetch removal) and 3 bug fixes are all sound, but neither PR can merge as-is due to the PR #97 baggage (schema migrations v12-v19, action bar, JSONL pruning, whitespace noise). Recommend extracting the workspace commits into a clean PR rebased on main. https://claude.ai/code/session_01XbMN35zn6yxTpYWbNzh57h
Midway65
added a commit
to Midway65/nexus
that referenced
this pull request
Apr 7, 2026
…pse#106, ProfSynapse#107, ProfSynapse#112–ProfSynapse#115) Merges upstream/main (35bed84) into my-custom-branch. Fork additions preserved: - HybridStorageAdapter: pruneOrphanedConversationFiles() re-added (fork: temporary cleanup) - SQLiteMaintenanceService: fixVec0TableDimensions() added (fork: vec0 768→384 fix) - SQLiteCacheManager: calls fixVec0TableDimensions() after migrations - JSONLWriter: readEventsStreaming() kept; size-check in readEvents() for >50MB files; stat() call made optional-chain safe for test environments - MessageBubble: action bar import, field, appendActionBar/cleanupActionBar methods, call sites in createElement/updateWithNewMessage/rebuildElement/cleanup; ToolBubbleFactory call uses 3-param signature (action bar owns copy) Upstream changes taken entirely: - ProviderHttpClient: dropped our require() fix; took upstream desktopRequire version - ConversationRepository: dropped JSONL file-delete; took upstream tombstone approach - ModelAgentManager: 5-service split (PRs ProfSynapse#112) - SQLiteCacheManager: 6-file split (PR ProfSynapse#113); facade kept; new services accepted - MessageBubble: 527-line refactor with 4 helper classes (PR ProfSynapse#115) - PluginScopedStorage: new PluginScopedStorageCoordinator + PluginStoragePathResolver - 9 new test files accepted from upstream .gitignore: added !docs/review/ exception (pattern consistent with other doc dirs) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both PRs carry the full PR #97 payload (previously partially rejected)
with workspace optimization commits stacked on top. The new workspace
work (two-tier prompt, cheap restore, dead fetch removal) and 3 bug
fixes are all sound, but neither PR can merge as-is due to the PR #97
baggage (schema migrations v12-v19, action bar, JSONL pruning,
whitespace noise). Recommend extracting the workspace commits into a
clean PR rebased on main.
https://claude.ai/code/session_01XbMN35zn6yxTpYWbNzh57h