fix: audit fixes for PR #138 JSONL-triggered SQLite sync#139
Open
ProfSynapse wants to merge 1 commit into
Open
fix: audit fixes for PR #138 JSONL-triggered SQLite sync#139ProfSynapse wants to merge 1 commit into
ProfSynapse wants to merge 1 commit into
Conversation
Address findings from post-merge audit of PR #138: - H1: Add sync concurrency guard in SyncCoordinator (prevent overlapping sync runs) - M1: Change self-write suppression to TTL-based (handle shard rotation) - M2: Add expired suppression entry sweep in scheduleDispatch - M3: Skip WorkspacesTab re-render during detail edit on unrelated sync - M4: Preserve ConversationList scroll position across sync re-renders - M5+L4: Add 8 new tests (create/delete events, error resilience) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge audit of PR #138 identified 1 HIGH, 4 MEDIUM, and 6 LOW findings across architecture, backend, frontend, and test coverage. This PR addresses the HIGH and all MEDIUMs:
Test plan
🤖 Generated with Claude Code