Skip to content

Check statement format against property definition format #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JeroenDeDauw wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Check statement format against property definition format #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Neo/neojs/src/domain/SubjectValidator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,17 @@ export class SubjectValidator {
return true; // Statements for unknown properties are considered valid
}

const property = schema.getPropertyDefinitions().get( statement.propertyName );

if ( property.format !== statement.format ) {
return false; // Values in the wrong format are considered invalid
}

const errors =
this.getValueFormat( statement )
.validate(
.validate( // TODO: maybe we need to verify the statement value matches the statement format
statement.value,
schema.getPropertyDefinitions().get( statement.propertyName )
property
);

return errors.length === 0;
Expand Down
Loading