Fix PageDeleteComplete hook calling getTitle() on ProperPageIdentity#86
Merged
Conversation
Fixes #85 The PageDeleteComplete hook passes a ProperPageIdentity (concretely a PageStoreRecord) as its first parameter, but the code called $page->getTitle() which does not exist on that interface. This caused a fatal error when deleting pages. Use Title::newFromPageIdentity() instead, which correctly creates a Title from any PageIdentity. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
============================================
+ Coverage 92.11% 92.29% +0.17%
Complexity 166 166
============================================
Files 17 17
Lines 571 571
============================================
+ Hits 526 527 +1
+ Misses 45 44 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85
The
PageDeleteCompletehook passes aProperPageIdentity(concretely aPageStoreRecord) as its first parameter, but the code called$page->getTitle()which does not exist on that interface. This causeda fatal error when deleting pages. Use
Title::newFromPageIdentity()instead, which correctly creates a Title from any PageIdentity.
The other two hooks (
PageSaveCompleteandPageMoveComplete) are unaffected —PageSaveCompletereceives aWikiPagewhich hasgetTitle(), andPageMoveCompletealready receivesTitleobjects directly.Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com