Fix MW 1.47 compatibility: OutputPage::parserOptions() was removed#51
Merged
malberts merged 1 commit intoJul 16, 2026
Merged
Conversation
OutputPage::parserOptions() was removed in MediaWiki core (wikimedia/mediawiki@3772013). FormatterBuilder still called it, causing FormattingTest::testHtmlFormat to fail on MW master and item pages with localMedia statements to fatal on MW 1.47. Use ParserOptions::newFromContext() instead, which is available in all supported MediaWiki versions. Fixes ProfessionalWiki#50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OutputPage::parserOptions() was removed in MediaWiki core (wikimedia/mediawiki@3772013). FormatterBuilder still called it, causing FormattingTest::testHtmlFormat to fail on MW master and item pages with localMedia statements to fatal on MW 1.47.
Use ParserOptions::newFromContext() instead, which is available in all supported MediaWiki versions.
Fixes #50
Same approach as #46 by @a-random-lemurian.
Verification:
FormattingTest::testHtmlFormatfails on MW master without this change(failing run)
and passes with it (CI on this PR, all 8 MW versions green)
item pages with localMedia statements render correctly again.