Skip to content

Fix/form error message#24

Merged
luis0ares merged 4 commits intoProgramadoresSemPatria:developfrom
pedrogagodev:fix/form-error-message
Mar 14, 2026
Merged

Fix/form error message#24
luis0ares merged 4 commits intoProgramadoresSemPatria:developfrom
pedrogagodev:fix/form-error-message

Conversation

@pedrogagodev
Copy link
Contributor

Summary

Implements comprehensive improvements to form validation feedback and accessibility across multiple application modals.
Enhances clarity of validation errors, visual feedback for invalid fields, and ARIA accessibility to improve usability and screen reader support.

Type of Change

  • Feature
  • Fix
  • Improvement
  • Refactor
  • Documentation

Included Changes

Improvements

  • Added specific validation error messages below inputs/selects in:

    • AddApplicationModal
    • EditApplicationModal
    • FinalizeApplicationModal
    • AddStepModal
    • EditStepModal
  • Implemented visual error states for inputs and ListBoxSelect (red border on validation failure).

  • Enhanced accessibility with proper ARIA attributes:

    • Linked error messages using aria-describedby
    • Marked invalid fields with aria-invalid="true"
    • Added role="alert" to error message elements for screen reader announcement
  • Refined Zod schema validation messages with clearer, user-friendly feedback (e.g., required field messages).

  • Updated DateInput and ListBoxSelect components to support error states and ARIA attributes.

  • Standardized default value for platform_id in AddApplicationModal from undefined to 0 to match schema validation.

Testing

Manual testing involves creating and editing new applications and phases, as well as finalizing an application.

Since this was meant to be a quick fix, I didn't add any unit or integration tests. But I plan to add tests for the next feature I'm working on.

  • Unit tests
  • Integration tests
  • Manual testing
  • N/A

Notes

  • Focused on improving UX consistency and accessibility compliance across all form modals.
  • No breaking changes expected.

Checklist

  • Self-review completed
  • CI passing
  • Ready to merge

@luis0ares luis0ares merged commit b9727e0 into ProgramadoresSemPatria:develop Mar 14, 2026
1 check passed
@luis0ares luis0ares mentioned this pull request Mar 14, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants