Fix/form error message#24
Merged
luis0ares merged 4 commits intoProgramadoresSemPatria:developfrom Mar 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements comprehensive improvements to form validation feedback and accessibility across multiple application modals.
Enhances clarity of validation errors, visual feedback for invalid fields, and ARIA accessibility to improve usability and screen reader support.
Type of Change
Included Changes
Improvements
Added specific validation error messages below inputs/selects in:
AddApplicationModalEditApplicationModalFinalizeApplicationModalAddStepModalEditStepModalImplemented visual error states for inputs and
ListBoxSelect(red border on validation failure).Enhanced accessibility with proper ARIA attributes:
aria-describedbyaria-invalid="true"role="alert"to error message elements for screen reader announcementRefined Zod schema validation messages with clearer, user-friendly feedback (e.g., required field messages).
Updated
DateInputandListBoxSelectcomponents to support error states and ARIA attributes.Standardized default value for
platform_idinAddApplicationModalfromundefinedto0to match schema validation.Testing
Manual testing involves creating and editing new applications and phases, as well as finalizing an application.
Since this was meant to be a quick fix, I didn't add any unit or integration tests. But I plan to add tests for the next feature I'm working on.
Notes
Checklist