Conversation
|
Test on Playground |
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the "Filter by source" dropdown in DataTables was only populated with plugin names visible on the first page of results. With server-side pagination, many plugin names were missing from the dropdown. The fix collects all unique plugin sources before applying any filters or pagination, and passes them to the frontend via the AJAX response.
Key changes:
- Backend endpoints now collect and return all unique plugin sources in the
sourcesfield of the response - Frontend stores sources from AJAX responses and uses them to populate filter dropdowns
- Filtering logic in
get_options_that_do_not_exist()refactored to build full data structure before filtering
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/class-rest.php |
Added logic to collect all unique plugin sources before filtering/pagination in three REST endpoints (get_unused_options, get_used_not_autoloaded_options, get_options_that_do_not_exist), and includes them in the response as sources array |
js/admin-script.js |
Added tableSources storage object, created createColumnFilterSetup helper to bind table selectors, updated dataSrc callbacks to store sources from AJAX responses, and modified setupColumnFilters to use stored sources for server-side tables while falling back to column data for client-side tables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aristath
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Filter by source" dropdown is populated based only on the options visible on the first page of results, but since DataTables uses server-side pagination, there are other plugin names that aren't included in the filter dropdown.
This PR fixes that issue.