Rename plugin from pp-glossary to your-glossary#54
Open
Rename plugin from pp-glossary to your-glossary#54
Conversation
Signed-off-by: Filip Ilic <ilic.filip@gmail.com>
Contributor
|
Test on Playground |
Contributor
🔍 WordPress Plugin Check Report
📊 Report
❌ Errors (65)📁 includes/class-meta-boxes.php (16 errors)
📁 includes/class-settings.php (15 errors)
📁 includes/class-content-filter.php (5 errors)
📁 includes/class-post-type.php (24 errors)
📁 includes/class-blocks.php (4 errors)
📁 includes/functions.php (1 error)
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
textdomain_mismatch | The "Text Domain" header in the plugin file does not match the slug. Found "your-glossary", expected "pp-glossary". |
📁 readme.txt (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
mismatched_plugin_name | Plugin name "Glossary" is different from the name declared in plugin header "Your Glossary". |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
Renames namespace (Your_Glossary), constants (YOUR_GLOSSARY_*), function prefixes (your_glossary_*), text domain (your-glossary), CSS classes, asset handles, filter names, and config files. Database identifiers kept unchanged for backwards compatibility: post type slug (pp_glossary), meta key (_pp_glossary_data), option name (pp_glossary_settings), block name (pp-glossary/glossary-list). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Filip Ilic <ilic.filip@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Filip Ilic <ilic.filip@gmail.com>
Add migration to rename all database identifiers: - Post type: pp_glossary -> your_glossary - Meta key: _pp_glossary_data -> _your_glossary_data - Option: pp_glossary_settings -> your_glossary_settings - Block name in content: wp:pp-glossary/glossary-list -> wp:your-glossary/glossary-list Update all code references to use new DB identifiers. Bump version from 1.3.2 to 1.4.0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Filip Ilic <ilic.filip@gmail.com>
ilicfilip
changed the title
Old filter names (pp_glossary_excluded_tags, pp_glossary_disabled_post_types) still work but trigger _doing_it_wrong notices pointing to the new names. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Filip Ilic <ilic.filip@gmail.com>
- Update composer.lock content-hash to match renamed package in composer.json - Fix playground workflow to find main plugin file dynamically instead of hardcoding the repo name as the filename Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Filip Ilic <ilic.filip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete rename of the plugin from "Glossary" /
pp-glossaryto "Your Glossary" /your-glossary.Code-level renames
PP_Glossary→Your_GlossaryPP_GLOSSARY_*→YOUR_GLOSSARY_*pp_glossary_*()→your_glossary_*()pp-glossary→your-glossarypp_glossary_excluded_tags→your_glossary_excluded_tags,pp_glossary_disabled_post_types→your_glossary_disabled_post_typesDeprecated filter hooks
Old filter names still work but trigger
_doing_it_wrongnotices:pp_glossary_excluded_tags→ useyour_glossary_excluded_tagspp_glossary_disabled_post_types→ useyour_glossary_disabled_post_typesDatabase migration (1.4.0)
An automatic migration renames all stored data on upgrade:
pp_glossary→your_glossary_pp_glossary_data→_your_glossary_datapp_glossary_settings→your_glossary_settingswp:pp-glossary/glossary-list→wp:your-glossary/glossary-listFile/directory rename
pp-glossary.php→your-glossary.phppp-glossary/→your-glossary/) to be done at repo rename timeWordPress stores the active plugin path as
pp-glossary/pp-glossary.php. After the directory and file rename, WordPress will no longer find the plugin at that path and will silently deactivate it. Users must reactivate the plugin after updating. No data is lost — the migration handles all database changes automatically.CI note
The WordPress.org Plugin Check workflow fails because it derives the expected text domain from the plugin directory name (
pp-glossary), which no longer matches the new text domain (your-glossary). This will resolve once the repository is renamed toyour-glossary.Test plan
pp_glossarydatacomposer check-cs,composer lint,composer phpstanall pass🤖 Generated with Claude Code