-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add ConvNeXt for 1D, 2D and 3D inputs #8995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VenkateswarluNagineni
wants to merge
6
commits into
Project-MONAI:dev
Choose a base branch
from
VenkateswarluNagineni:feat/convnext
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
461afd0
feat(networks): add ConvNeXt for 1D, 2D and 3D inputs
VenkateswarluNagineni bb80ddb
feat(networks): validate ConvNeXt arguments and exercise aliases in t…
VenkateswarluNagineni db48c65
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b167de5
feat(networks): promote LayerNormNd to a public layer
VenkateswarluNagineni 4522db2
fix(networks): satisfy mypy and docs build for ConvNeXt
VenkateswarluNagineni 998e5c1
fix(networks): render LayerNormNd shape notation as literals
VenkateswarluNagineni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| # Copyright (c) MONAI Consortium | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import torch | ||
| import torch.nn as nn | ||
|
|
||
|
|
||
| class LayerNormNd(nn.Module): | ||
| """ | ||
| Layer normalization over the channel dimension of a channels-first tensor. | ||
|
|
||
| `torch.nn.LayerNorm` normalizes over the trailing dimensions, so it expects a channels-last layout | ||
| such as ``(batch, *spatial, channel)``. Convolutional feature maps in MONAI are channels-first, | ||
| ``(batch, channel, *spatial)``, and this module normalizes those over the channel dimension only, | ||
| for any number of spatial dimensions. | ||
|
|
||
| Args: | ||
| num_channels: number of channels of the input, i.e. the size of dimension 1. | ||
| spatial_dims: number of spatial dimensions of the input image. | ||
| eps: value added to the denominator for numerical stability. | ||
| """ | ||
|
|
||
| def __init__(self, num_channels: int, spatial_dims: int, eps: float = 1e-6) -> None: | ||
| super().__init__() | ||
| self.eps = eps | ||
| self.weight = nn.Parameter(torch.ones(num_channels)) | ||
| self.bias = nn.Parameter(torch.zeros(num_channels)) | ||
| # broadcast the affine parameters against (batch, channel, *spatial); precomputed so that the | ||
| # module is scriptable without inspecting the rank of the input at runtime. | ||
| self.param_shape = [1, num_channels] + [1] * spatial_dims | ||
|
|
||
| def forward(self, x: torch.Tensor) -> torch.Tensor: | ||
| mean = x.mean(dim=1, keepdim=True) | ||
| var = (x - mean).pow(2).mean(dim=1, keepdim=True) | ||
| x = (x - mean) / torch.sqrt(var + self.eps) | ||
| return self.weight.view(self.param_shape) * x + self.bias.view(self.param_shape) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Reject invalid layer dimensions.
Negative
spatial_dimsproduces an affine shape that can broadcast over the wrong axis;num_channels=0also creates an unusable layer. Validate both and add invalid-argument tests.Proposed fix
def __init__(self, num_channels: int, spatial_dims: int, eps: float = 1e-6) -> None: super().__init__() + if num_channels <= 0: + raise ValueError("num_channels must be positive.") + if spatial_dims < 0: + raise ValueError("spatial_dims must be non-negative.") self.eps = epsAs per path instructions, “Examine code for logical error or inconsistencies” and ensure modified definitions have unit tests.
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Path instructions