Fix tracing-state leak after transform exceptions#9019
Open
yinkev wants to merge 1 commit into
Open
Conversation
Signed-off-by: kyinhub <kevinpyin@gmail.com>
Contributor
📝 WalkthroughWalkthrough
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7701.
Description
TraceableTransform.trace_transform()now restores the previous tracing state even when code inside the context manager raises. The original exception still propagates unchanged.The previous implementation restored
self.tracingonly after a normalyield, so an exception permanently leaked the temporary tracing value into the transform. This caused later inverse transforms to fail withTransform Tracing must be enabledafter a caught CUDA OOM or another runtime exception.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.Validation
upstream/devbecause the tracing state remains changed after an exception.python -m pytest tests/transforms/inverse/test_traceable_transform.py -q: 2 passed.git diff --checkpasses.