[codex] polish 0.5 persistence and manifest release surfaces#247
Conversation
b66ce36 to
b36182f
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces in-memory stream loading and writing capabilities (write_to, read_from, and load_from_bytes) across all index types, allowing fuzz targets to run directly on byte slices without temporary scratch files. It also updates documentation and release checks to support sidecar-backed bundles and ensure metadata parity. However, a critical correctness issue was identified in the new load_*_from functions: unconditionally wrapping the user-provided reader in a BufReader can cause it to buffer and discard bytes past the index payload, which breaks the ability to read indexes embedded within larger streams.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
b36182f to
1a30e9d
Compare
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
/agentic_review |
Signed-off-by: Nelson Spence <nelson@projectnavi.ai>
1a30e9d to
8bd1ec4
Compare
Summary
This PR polishes the high-leverage pre-0.5 release surfaces from the Pareto rollup:
Rank,RankQuant,Bitmap,SignBitmap, andRankQuantFastscanload_from_bytesdirectly instead of scratch filesmanifest.json + index.ovrq + ids.binbundle flow, row-identity boundary codes, and stable sidecar report fields/statesCloses #132.
Closes #135.
Closes #197.
Closes #198.
Closes #199.
Closes #212.
Refs #148.
Notes
#148 remains referenced rather than closed because this PR documents the current report shape and sidecar state contract, but broader future report-state additions can still land separately.
#241 remains a dev-only advisory follow-up.
cargo audit --deny warningsstill reports onlyRUSTSEC-2025-0141throughbenchmarks/beir-bench -> hnsw_rs -> bincode; the shipped crates are not blocked by this PR.#246 tracks the post-0.5 synthetic benchmark delta investigation and is intentionally non-blocking.
Validation
cargo fmt --checkpython tests/release_publish_invariants.pygit diff --checkcargo test --lockedcargo test --locked -p ordvec-manifest --features clicargo check --lockedcargo check --manifest-path fuzz/Cargo.toml --lockedcargo audit --ignore RUSTSEC-2025-0141 --deny warningsExpected advisory state:
cargo audit --deny warningsreportsRUSTSEC-2025-0141only via the dev-only BEIR benchmark crate dependency path.