Skip to content

fix(ci): coverage floor failed on main — lower below the non-AVX-512 figure#67

Merged
Navi Bot (project-navi-bot) merged 1 commit into
mainfrom
fix/coverage-floor-avx512
May 26, 2026
Merged

fix(ci): coverage floor failed on main — lower below the non-AVX-512 figure#67
Navi Bot (project-navi-bot) merged 1 commit into
mainfrom
fix/coverage-floor-avx512

Conversation

@Fieldnote-Echo

Copy link
Copy Markdown
Member

Main's coverage job went red after #63 merged (and #64 too). Root cause: the coverage runner (ubuntu-latest) has no AVX-512, so the runtime SIMD dispatch never exercises the AVX-512 kernels (bitmap/quant_kernels/sign_bitmap), and line coverage measured there is 81.92% — not the ~90% an AVX-512 host sees. The 85% floor I added in #63 was calibrated against an AVX-512-inflated local number (my machine has AVX-512). This lowers the floor to 78%, below the non-AVX-512 figure, so main and #64 go green. The AVX-512 paths remain covered by the separate avx512 job under Intel SDE. Follow-up worth filing: run the coverage job under SDE for the accurate ~90% number and a tighter, criterion-guarding floor.

Main's coverage job went red after #63 merged. The ubuntu-latest coverage runner has no AVX-512, so the runtime SIMD dispatch never exercises the AVX-512 kernels (bitmap/quant_kernels/sign_bitmap); line coverage measured there is 81.92%, not the ~90% an AVX-512 host (or the avx512 SDE job) reaches. The 85% floor added in #63 was calibrated against an AVX-512-inflated local number, so it failed on main and #64. Lower it to 78%, safely under the AVX-512-free figure; the AVX-512 paths stay covered by the avx512 job under SDE. Follow-up: run the coverage job under SDE for the accurate number and a tighter floor.

Signed-off-by: Nelson Spence <nelson@projectnavi.ai>
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Lower coverage floor to 78% for non-AVX-512 runner

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Lower coverage floor from 85% to 78% to account for AVX-512 unavailability
• Runner lacks AVX-512 support, so SIMD kernels unmeasured in coverage
• AVX-512 paths remain covered by separate SDE job
• Updated comments explaining the floor rationale and limitations
Diagram
flowchart LR
  A["Coverage Runner<br/>No AVX-512"] -->|"SIMD dispatch<br/>skips AVX-512"| B["Measured Coverage<br/>~82%"]
  C["AVX-512 Kernels<br/>bitmap/quant_kernels"] -->|"Covered by"| D["SDE Job<br/>~90% coverage"]
  B -->|"Floor set to"| E["78% Threshold<br/>Safe margin"]

Loading

File Changes

1. .github/workflows/coverage.yml 🐞 Bug fix +12/-6

Adjust coverage floor and document AVX-512 limitations

• Reduced --fail-under-lines threshold from 85 to 78 percent
• Expanded comments explaining AVX-512 coverage gap and runner limitations
• Clarified that AVX-512 kernels are exercised by separate SDE job
• Added follow-up note about running coverage job under SDE for accurate measurements

.github/workflows/coverage.yml


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented May 26, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@project-navi-bot Navi Bot (project-navi-bot) merged commit ac3a238 into main May 26, 2026
21 checks passed
@project-navi-bot Navi Bot (project-navi-bot) deleted the fix/coverage-floor-avx512 branch May 26, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants