fix(ci): coverage floor failed on main — lower below the non-AVX-512 figure#67
Merged
Merged
Conversation
Main's coverage job went red after #63 merged. The ubuntu-latest coverage runner has no AVX-512, so the runtime SIMD dispatch never exercises the AVX-512 kernels (bitmap/quant_kernels/sign_bitmap); line coverage measured there is 81.92%, not the ~90% an AVX-512 host (or the avx512 SDE job) reaches. The 85% floor added in #63 was calibrated against an AVX-512-inflated local number, so it failed on main and #64. Lower it to 78%, safely under the AVX-512-free figure; the AVX-512 paths stay covered by the avx512 job under SDE. Follow-up: run the coverage job under SDE for the accurate number and a tighter floor. Signed-off-by: Nelson Spence <nelson@projectnavi.ai>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Review Summary by QodoLower coverage floor to 78% for non-AVX-512 runner
WalkthroughsDescription• Lower coverage floor from 85% to 78% to account for AVX-512 unavailability • Runner lacks AVX-512 support, so SIMD kernels unmeasured in coverage • AVX-512 paths remain covered by separate SDE job • Updated comments explaining the floor rationale and limitations Diagramflowchart LR
A["Coverage Runner<br/>No AVX-512"] -->|"SIMD dispatch<br/>skips AVX-512"| B["Measured Coverage<br/>~82%"]
C["AVX-512 Kernels<br/>bitmap/quant_kernels"] -->|"Covered by"| D["SDE Job<br/>~90% coverage"]
B -->|"Floor set to"| E["78% Threshold<br/>Safe margin"]
File Changes1. .github/workflows/coverage.yml
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
project-navi-bot
approved these changes
May 26, 2026
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's coverage job went red after #63 merged (and #64 too). Root cause: the coverage runner (ubuntu-latest) has no AVX-512, so the runtime SIMD dispatch never exercises the AVX-512 kernels (bitmap/quant_kernels/sign_bitmap), and line coverage measured there is 81.92% — not the ~90% an AVX-512 host sees. The 85% floor I added in #63 was calibrated against an AVX-512-inflated local number (my machine has AVX-512). This lowers the floor to 78%, below the non-AVX-512 figure, so main and #64 go green. The AVX-512 paths remain covered by the separate avx512 job under Intel SDE. Follow-up worth filing: run the coverage job under SDE for the accurate ~90% number and a tighter, criterion-guarding floor.