Conversation
…art-Event-Booking into feature/11-implement-event-data-model-and-storagfe
…lass to controller execution of db queries at the service layer
…default admin account
…t-event-data-model-and-storagfe Feature/11 implement event data model and storage
…thentication-infrastructure-for-smart-event-booking Feature/3 set up authentication infrastructure for smart event booking
Introduce authentication UI and logic: add AuthController (Register, Login, Logout) wired to IAuthService; add Razor views for Login and Register. Enhance DTOs with data annotations for validation (LoginDto, RegisterDto). Update shared layout to show login/register or logout and user name based on authentication. Add unit tests for AuthController registration flows (Moq, FluentAssertions).
The fixes included: 1. AuthServiceTests.cs: Added missing ILogger<AuthService> mock and updated assertions to align with the transaction-based implementation. 2. AuthService.cs: Removed redundant password comparison as it's now handled by DTO data annotations. 3. UnitOfWork: Implemented IAsyncDisposable for proper transaction cleanup and updated DI registration. 4. Integration Tests: Updated IdentitySeederTests.cs to use await using var scope = provider.CreateAsyncScope() to support the new IAsyncDisposable implementation of UnitOfWork.
- Move SignInAsync inside transaction boundary in AuthService - Remove redundant explicit rollbacks in UnitOfWork and AuthService - Consolidate UnitOfWork DI registration - Refactor AuthControllerTests to remove magic strings in assertions
Expose synchronous disposal on the unit-of-work by adding IDisposable to IUnitOfWork and implementing Dispose in UnitOfWork (disposes current transaction and suppresses finalization). Also switch InitialiseDatabaseAsync to use CreateAsyncScope with await using so the service scope is asynchronously disposed. These changes improve disposal semantics and ensure transactions/scopes are properly cleaned up.
feat: implement create, update and delete operations
…-user-registration Feature/4 implement user registration
Wrap user registration in the unit of work execution strategy so transactional identity operations can be retried safely and avoid InvalidOperationException during registration. Add unit of work support for execution strategies, update auth service to use it, and extend tests to verify the new flow.
Configure the API cookie for secure cross-origin requests and allow credentialed CORS from the Angular client. Add a global HTTP interceptor so browser requests include cookies automatically during authentication.
…-user-login #5 implement user login
Co-authored-by: Copilot <copilot@github.com>
… and add some styles to categories on frontend
…outes-and-pages-with-authentication #8-protect-routes-and-pages
…t-route-guard Feature/43 implement route guards
…ller, app.routes, and auth.service
…ration-page #44 implement registration page
…es-are-not-created-when-event-is-created Fix/fix categories and venues on backend and frontend
…t-cicd Feature/27 implement cicd
…nd-routes Fixed swagger and paths on frontend
eevatsen
approved these changes
Apr 30, 2026
fhyhtyh
approved these changes
Apr 30, 2026
mykhailo-bi
approved these changes
Apr 30, 2026
mykhailo-bi
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.