Draft
Conversation
…ed refactor of vision systems. General encapsulation improvements.
…ed stuff, used reflection to auto-init everything in SD, removed unneeded keys, simplified coralroller, removed algaeroller, simplified RumbleRequester, renamed copilot to operator, organised utils a bit, changed switches to new syntax
…imelight, started tidying up vision rotation fetching
…er for Keys, removed unused methods in Robot
…d other things to use those implementations
… pathplanner remnants
…itialisation, anonymising methods)
…ew repo for long-term codebase
Lego-archer-elf
approved these changes
Sep 26, 2025
Contributor
Lego-archer-elf
left a comment
There was a problem hiding this comment.
The system will need to be thoroughly tested to ensure everything still works and communicates as intended, but this all looks reasonable.
Only change I'd request is to have the limelight names moved to ID constants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically a dump of code restructuring changes I want to be in the long-term codebase. Not really intended for much use on this robot, I'll leave this PR as a draft so it can't be actually merged.
List of changes:
this::methodrather than() -> method()).That should be most of it, but I'm bound to have missed one or two things.