add import and directory support to export map subpath exports#672
Merged
thescientist13 merged 1 commit intoJul 28, 2021
Conversation
This was referenced Jul 25, 2021
Member
Author
|
As a simple test, tried commenting out the Can re-evaluate further in #674 if desired, since no big changes you should really happen in a patch fix, IMO. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related Issue
resolves #671
Summary of Changes
importMapimportDiscussion
I'm thinking now, based on the nature of this fix, if we actually stillvneed
walkModuleto manually crawl all theimports andexports of every dependency to add to theimportMap?. I would be curious to try now with this bug fix to see if ourimportMapstill works without it? Maybe should happen as part of a minor release though, so this PR can just go out as a patch.Additionally, not sure if a sub path export is a directory, does that mean we should recursively export everything? Could be part of an issue that also addresses the above question re:
walkModule, which coincidentally, I've playing around with in #668Update: made a quick test ( #672 (comment) ) so seems like it is still needed.