filter import map entries and handle relative exports from dependency entry points#749
Merged
thescientist13 merged 3 commits intoOct 20, 2021
Conversation
thescientist13
commented
Oct 15, 2021
| console.debug('entryPath', entryPath); | ||
| console.debug('entry', entry); | ||
| if (path.extname(entryPath) !== '') { | ||
| importMap[entry] = entryPath; |
Member
Author
There was a problem hiding this comment.
oh, this is just the same line, no need for the conditional? I think maybe it was supposed to be
if (path.extname(entryPath) !== '') {
entryPath = `${entryPath}.js`;
}291e2df to
e242b87
Compare
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #748 and #773 to fix issues observed while integrating MWC - ProjectEvergreen/greenwood-getting-started#42
Summary of Changes
TODO