Merge master into additionalpendulumsummon branch#1188
Merged
pyrQ merged 130 commits intoadditionalpendulumsummonfrom Jun 25, 2025
Merged
Merge master into additionalpendulumsummon branch#1188pyrQ merged 130 commits intoadditionalpendulumsummonfrom
pyrQ merged 130 commits intoadditionalpendulumsummonfrom
Conversation
SET_DOOM_KING = 0x1c8
was not retrieving the player's chosen effect in the operation
- Should be able to target a "D/D/D" Synchro Monster with 0 ATK (as long as the opponent controls a monster with 0 DEF). - Any Trap Monsters that are still Traps that have their effects negated by this card's effect shoul only have their monster effects negated, not their Trap effects as well (they should stay in the Monster Zone).
Fixed a bug where a "D/D/D Oracle King d'Arc" special summoned by its effect could change the damage to LP recover, when its effect should not apply in that situation
Indentation fix.
Effect to place in Pendulum Zone should not be OPT.
Prevent script error
Moved `announce_filter` to the `s` table so that "Engraver of the Mark" could access it.
Fixed some edge cases with the Pendulum effect where the player could Special Summon from the face-up Extra Deck and deliberately block the only Main Monster Zone that could've been used to Special Summon from the Main Deck.
Fixed a bug where it could be summoned using Spellcaster monsters that could not be banished
Fixed some cards that were not passing a group or passing an incorrect group in one of the arguments of this function, leading to script errors
It was using an incorrect description for the additional Pendulum Summon
missing keyword in a previous change
Fixed an incorrect interaction of the effect to double the ATK of the monster returned to the field with other ATK/DEF modifiers
Updated the selection procedure to make so the player is allowed to unselect the first card and restart the process
Fixed a bug where it would be possible to activate the GY effect even if "Ghostrick Shot" was the only "Ghostrick" card in the GY
Keep its interaction vs Necrovalley consistent with other Fusion effects that can use materials from the GY
Should only trigger if an "R.B." monster leaves the field by card effect specifically.
Added handling to skip the selection process for the Ritual Monster if the effect is Ritual Summoning the card itself.
- its search effect should be hard once per turn - had mismatched parameter names in the target and operation, causing `chk` to be improperly checked
typo from previous commit
Should exclude itself when considering what can be Tributed for the Ritual Summon, but only for the activation check.
Should exclude itself when considering what can be Tributed for the Ritual Summon, but only for the activation check.
Prevent effects that can use an extra group of materials (e.g. "Lubellion the Searing Dragon") and interact with the GY from bypassing "Necrovalley"'s effect
- use unused function (s.ritop) - formatting
- Fixed the string used as description when the player has to target a monster - general script modernization
- Crusadia Vanguard: Should be negatable by an effect such as that of "Ghost Belle & Haunted Mansion" if you activate it by Tributing a monster. - Cubic Rebirth: Should be treated as an effect that includes Special Summoning from the hand, Deck, and GY. - Goddess Verdande's Guidance: Its second effect should be negatable by an effect such as that of "Ash Blossom & Joyous Spring". - Luminous Dragon Ritual: Banishing and Special Summoning should be treated as happening at the same time. Should still banish even if there's no "Paladin of Photon Dragon" in your hand on resolution. - Rebirth of the Seventh Emperors: The damaging effect should be applied even if the target isn't there anymore on resolution. - Reincarnation of the Seventh Emperors: Should be treated as an effect that includes Special Summoning and inflict damage.
Prevent script errors when the destruction doesn't happen due to an event
- Added extra checks to see if there were free zones on resolution - Should be able to Summon this card in either Attack or Defense Position
Fixed a bug where it would not be able to change the position of a monster that could not be targeted by its effect
Fixed a bug where it would consider the ATK of monsters that were face-down when inflicting damage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.