Update mechanism for marking effects ("register flags")#1190
Merged
that-hatter merged 11 commits intomasterfrom Jun 29, 2025
Merged
Update mechanism for marking effects ("register flags")#1190that-hatter merged 11 commits intomasterfrom
that-hatter merged 11 commits intomasterfrom
Conversation
Since `Card.RegisterEffect` loops through the passed register flags, they don't need to have unique bits. This removes the unnecessary conversion step from flag to code.
A function for retrieving a card's effects that were registered with "register flags". This returns the actual effects directly, instead of the flag effects that have them as label object (which is what `GetCardEffect` returns).
Made the card use `GetEffectsWithRegisterFlag` instead of `GetCardEffect`.
Since `Card.RegisterEffect` loops through the passed register flags, they don't need to have unique bits. This removes the unnecessary conversion step from flag to code.
A function for retrieving a card's effects that were registered with "register flags". This returns the actual effects directly, instead of the flag effects that have them as label object (which is what `GetCardEffect` returns).
Made the card use `GetEffectsWithRegisterFlag` instead of `GetCardEffect`.
…cripts into register-flag
old REGISTER_FLAG constants will still work but are deprecated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REGISTER_FLAG_constants toEFFECT_MARKER_constants and updated usesCard.GetMarkedEffectshelper function to fetch a card's effects that were registered with a marker