Deprecate existing effect markers#1199
Merged
that-hatter merged 166 commits intomasterfrom Jul 12, 2025
Merged
Conversation
added mechanism for tracking functions that were generated with Cost.Detach
* use new function for checking effects with a detach cost * modernization
* use new function for checking effects with a detach cost * modernization
track functions created by SelfDiscard and SelfDiscardToGrave
…m/ProjectIgnis/CardScripts into deprecate-existing-effect-markers
that-hatter
pushed a commit
to ProjectIgnis/BabelCDB
that referenced
this pull request
Jul 12, 2025
To match the script updates from ProjectIgnis/CardScripts#1199 (both are to be merged together) List of updated cards: \- Exosister Gibrine \- Flower Cardian Cherry Blossom \- Flower Cardian Peony with Butterfly \- Number F0: Utopic Future Slash \- Number S39: Utopia Prime \- Number 6: Chronomaly Atlandis \- Number 42: Galaxy Tomahawk \- Number 46: Dragluon \- Number 82: Heartlandraco \- Number 87: Queen of the Night \- Number 91: Thunder Spark Dragon \- Primathmech Alembertian \- Satellarknight Rigel \- Tellarknight Ptolemaeus \- CXyz Barian Hope (Anime) \- Number S39: Utopia Prime (Manga) \- Overlay Wedge \- Raidraptor - Rapid Xyz \- Rank-Up-Magic Cipher Pursuit \- Ultimate Full Burst \- Utopia Rising \- XYZ Wings
YgoproStaff
pushed a commit
to ProjectIgnis/DeltaBagooska
that referenced
this pull request
Jul 12, 2025
To match the script updates from ProjectIgnis/CardScripts#1199 (both are to be merged together) List of updated cards: \- Exosister Gibrine \- Flower Cardian Cherry Blossom \- Flower Cardian Peony with Butterfly \- Number F0: Utopic Future Slash \- Number S39: Utopia Prime \- Number 6: Chronomaly Atlandis \- Number 42: Galaxy Tomahawk \- Number 46: Dragluon \- Number 82: Heartlandraco \- Number 87: Queen of the Night \- Number 91: Thunder Spark Dragon \- Primathmech Alembertian \- Satellarknight Rigel \- Tellarknight Ptolemaeus \- CXyz Barian Hope (Anime) \- Number S39: Utopia Prime (Manga) \- Overlay Wedge \- Raidraptor - Rapid Xyz \- Rank-Up-Magic Cipher Pursuit \- Ultimate Full Burst \- Utopia Rising \- XYZ Wings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the use of effect markers ("register flags") from every script, and adds a mechanism for identifying effects that previously had to use markers.
Costs created by the various
Costfunctions are now tracked in a local table, and can be checked using various new utility functions.EFFECT_MARKER_DRAGON_RULERandEFFECT_MARKER_THUNDRA- can now be checked usingEffect.HasSelfDiscardCostEFFECT_MARKER_DETACH_XMAT- can now be checked usingEffect.HasDetachCostEFFECT_MARKER_ALLURE_LVUP- can now be checked usingEffect.HasSelfToGraveCostThe other markers were not necessary, as the effects they mark could be checked in other ways.
EFFECT_MARKER_CARDIAN- by checking if the effect's type isEFFECT_SPSUMMON_PROCEFFECT_MARKER_TELLAR- by checking if the effect's code isEVENT_SUMMON_SUCCESSThe old mechanism for marking effects is kept in even if unused for the time being.
Cost.Detachis also renamed toCost.DetachFromSelfand various scripts that had to be edited were modernized.