Skip to content

Add index 307 :fast_thermalization to identifiers#86

Closed
nanshi1177 wants to merge 1 commit intomasterfrom
feat/fast-thermalization-index
Closed

Add index 307 :fast_thermalization to identifiers#86
nanshi1177 wants to merge 1 commit intomasterfrom
feat/fast-thermalization-index

Conversation

@nanshi1177
Copy link
Copy Markdown

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.76%. Comparing base (01f7aff) to head (bc0cc25).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   43.76%   43.76%           
=======================================
  Files          13       13           
  Lines       31243    31243           
=======================================
  Hits        13672    13672           
  Misses      17571    17571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmcclena
Copy link
Copy Markdown

@nanshi1177 I don't understand why this is needed. Why can't the thermalization source just go under the :nbi tag?

@bclyons12
Copy link
Copy Markdown
Collaborator

I agree that it's odd to need to add a tag for this. It seems like standard physics that they would have already accounted for. It would be good to find the appropriate tag in the existing IMAS schema if it exists.

@nanshi1177 nanshi1177 closed this Dec 4, 2025
@nanshi1177 nanshi1177 deleted the feat/fast-thermalization-index branch December 4, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants