Add index 307 :fast_thermalization to identifiers#86
Closed
nanshi1177 wants to merge 1 commit intomasterfrom
Closed
Add index 307 :fast_thermalization to identifiers#86nanshi1177 wants to merge 1 commit intomasterfrom
nanshi1177 wants to merge 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
=======================================
Coverage 43.76% 43.76%
=======================================
Files 13 13
Lines 31243 31243
=======================================
Hits 13672 13672
Misses 17571 17571 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@nanshi1177 I don't understand why this is needed. Why can't the thermalization source just go under the |
Collaborator
|
I agree that it's odd to need to add a tag for this. It seems like standard physics that they would have already accounted for. It would be good to find the appropriate tag in the existing IMAS schema if it exists. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.