Add 2x splash image for Mac port with Retina display.#389
Add 2x splash image for Mac port with Retina display.#389mituharu wants to merge 1 commit intoProofGeneral:masterfrom
Conversation
erikmd
left a comment
There was a problem hiding this comment.
Thanks @mituharu! LGTM
In relation to that, I'd also like to improve toolbar icons on Retina displays (and Dark Mode on macOS 10.14).
README in the images directory tells that most of the images are created with Gimp and Inkscape.
If the toolbar icons are originally created as larger bitmaps or resolution-independent data like SVG and the original data are available somewhere, then I can generate high-resolution toolbar icons for Retina displays as multi-image TIFF data that Emacs Mac port prefers.
I don't know if such sources are available somewhere... Maybe @DavidAspinall would know?
Slightly off-topic, but: is there any reason not to use SVG icons directly? |
Because it takes time to setup WebKit (used for rendering SVG images in the Mac port) and makes startup slow. |
Emacs built with GTK+ first tries to let GTK+ render toolbar icon images and falls back on Emacs's own image rendering (see xg_get_image_for_pixmap in gtkutil.c). That's why SVG in the toolbar on GTK+ supports alpha channel but not inside Emacs buffers. |
|
Do we want to merge this as is? IS there something more to do? |
|
This is 5 years old now. Still no real reason not to merge. |

Emacs Mac port supports high-resolution (2x) image display for Retina displays.
One way to do that is just to add a file NAME@2x.EXT in parallel with existing NAME.EXT (no need to change Lisp code).
This pull request adds a 2x splash screen image so it looks crispier on Retina displays.
In relation to that, I'd also like to improve toolbar icons on Retina displays (and Dark Mode on macOS 10.14).
README in the
imagesdirectory tells that most of the images are created with Gimp and Inkscape.If the toolbar icons are originally created as larger bitmaps or resolution-independent data like SVG and the original data are available somewhere, then I can generate high-resolution toolbar icons for Retina displays as multi-image TIFF data that Emacs Mac port prefers.