Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on February 11
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| className="w-full max-w-sm space-y-4" | ||
| > | ||
| <FormSelect | ||
| control={control as any} |
There was a problem hiding this comment.
Demo uses type cast while storybook example doesn't
Low Severity
The demo file uses control={control as any} while the equivalent Storybook example at line 807 of form-abstractions.stories.tsx passes control={control} directly without any type cast. This inconsistency suggests either unnecessary type casting in the demo or a type inference issue that should be fixed. Since this demo is rendered in user-facing documentation and users may copy this pattern, it sets a bad precedent for how to use FormSelect.
There was a problem hiding this comment.
@irshathcodes please suggest on this. If I assign without keeping this open type, it warns in the editor.
|
We will create form abstractions for dropdowns later. |


This is the first round of review.
I do see some redundant files, but I am not sure about those. For e.g. theres a test file. But not sure if we are writing any test ATM.
Please suggest and I will make changes accordingly. Also, please make a new releasea of this ASAP coz I need this to be used in Move Bulk Actions sprint. Please find below screenshot.
All components form update is pending on me. Will do it on Monday.
Note
Medium Risk
Adds a new exported
FormSelectwrapper that wiresSelectFieldintoreact-hook-form, and extendsSelectField’s trigger API; moderate risk due to new form control behavior and prop-surface changes that could affect select rendering/label association.Overview
Adds
FormSelectto@px-ui/formsas a new form abstraction that wrapsSelectFieldwithreact-hook-formController, including passinginvalid,inputRef, and wiring label association via triggerid.Extends
SelectFieldby exportingSelectFieldPropsand addingtriggerPropssupport (merged withtriggerClassName) so callers can pass extraSelect.Triggerprops.Updates Storybook and docs to document/demo
FormSelect, and adjusts select/combobox example state typing fromundefinedtonullfor “no selection” cases.Written by Cursor Bugbot for commit 74b72ea. This will update automatically on new commits. Configure here.