Fix bcrypt hashing failure for passwords longer than 72 bytes#10
Open
ayushthoren wants to merge 1 commit intoProtonVPN:stablefrom
Open
Fix bcrypt hashing failure for passwords longer than 72 bytes#10ayushthoren wants to merge 1 commit intoProtonVPN:stablefrom
ayushthoren wants to merge 1 commit intoProtonVPN:stablefrom
Conversation
3 tasks
|
@ayushthoren, we shouldn't be silently truncating passwords. Disabling a test would be a better approach. There was already a backlash around it few years ago when people discover that ProtonMail is silently cutting their passwords - reddit post - ProtonMail cuts (silently) passwords at 73 characters |
Author
|
Ah, you're right... I think I needed to look at this from the perspective of fixing the test, not the code, since it seems to be expected that the test will fail. Because of this, I think rather than disabling the test entirely, it might be better to switch the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes password hashing failures caused by bcrypt’s hard limit of 72 bytes on input passwords.
Currently, the full password is passed directly into
bcrypt.hashpw(), which results in the error:ValueError: password cannot be longer than 72 bytes, truncate manually if necessaryThese changes manually truncate the password to avoid this issue.