Update API and WebSocket URLs to new production endpoint#137
Update API and WebSocket URLs to new production endpoint#137starknetdev wants to merge 5 commits intomainfrom
Conversation
Switch client network config from summit-production-69ed to summit-api-production-2 Railway deployment. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the client's network configuration to utilize new production API and WebSocket endpoints, ensuring seamless connectivity to the latest services. It also incorporates minor code formatting improvements to maintain code style consistency across the project. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
🚅 Deployed to the summit-pr-137 environment in Summit stack
1 service not affected by this PR
|
|
Claude finished @starknetdev's task —— View job Claude Review - General Engineering ReviewTodo List
run=23191258747 attempt=1 sha=bc559a9c7074ce2441eccb8f3f60fdcc616c35a5 scope=general Analysis ResultsThe git diff command targeting files outside the core app packages (contracts/, client/, indexer/, api/) returned no output. The only file changed in this PR is This PR contains:
Review FindingsNo issues found. Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO The changes in this PR are entirely within the client package and do not affect repository tooling, CI/CD workflows, shared configuration, or other general engineering concerns that fall within the scope of this review. |
Codex Review - General Engineering ReviewReview process failed to complete. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the API and WebSocket URLs to a new production endpoint. It also includes several formatting changes, such as adding trailing commas and standardizing object key quoting, which appear to be from a linter. The changes are consistent with the pull request's description. I have reviewed the changes and found no issues.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdded a defensive check in the Leaderboard address collection to skip falsy owners. Updated network configuration data (token addresses formatting, SN_MAIN API/WS URLs, object key formatting). Changed Summit indexer startingBlock value; minor string reformatting elsewhere. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Guard against null player.owner when building address lookup list, preventing TypeError on .replace() when leaderboard data contains entries with null owners. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codex Review - General Engineering ReviewReview process failed to complete. |
|
Claude finished @starknetdev's task —— View job Claude Review - General Engineering ReviewTodo List
run=23191323675 attempt=1 sha=0a43e8bd386a817f50fc9f7af0aff7c6823b26a8 scope=general Analysis ResultsThe git diff command targeting files outside the core app packages (contracts/, client/, indexer/, api/) returned no output. The only files changed in this PR are This PR contains:
Review FindingsNo issues found. Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO The changes in this PR are entirely within the client package and do not affect repository tooling, CI/CD workflows, shared configuration, or other general engineering concerns that fall within the scope of this review. |
…data Start indexing earlier to ensure beast Transfer events are captured before RewardsEarned events, preventing null owner entries in the rewards_earned table. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Claude finished @starknetdev's task —— View job Claude Review - General Engineering ReviewTodo List
run=23192833096 attempt=1 sha=0da378719aaa847be383c5365331cf3f04a18618 scope=general Analysis ResultsThe git diff command targeting files outside the core app packages (contracts/, client/, indexer/, api/) returned no output. The only files changed in this PR are This PR contains:
Review FindingsNo issues found. Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO The changes in this PR are entirely within the client and indexer packages and do not affect repository tooling, CI/CD workflows, shared configuration, or other general engineering concerns that fall within the scope of this review. |
Codex Review - General Engineering ReviewReview process failed to complete. |
|
Claude finished @starknetdev's task —— View job Claude Review - Indexer/API ReviewTodo List
run=23192833096 attempt=1 sha=0da378719aaa847be383c5365331cf3f04a18618 scope=indexer-api Analysis ResultsThe git diff shows changes only in The changes in
Review Findings[MEDIUM] indexer/apibara.config.ts:39 - Starting block lowered from 7077225 to 2209820 without justification or migration strategy
Positive ObservationsThe formatting changes (lines 7-35) improve code readability by breaking long hex addresses into multi-line format, which aligns with standard linting practices. Summary: 0 CRITICAL, 0 HIGH, 1 MEDIUM, 0 LOW, 0 INFO |
Codex Review - Indexer/API ReviewReview process failed to complete. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@indexer/apibara.config.ts`:
- Line 39: The change to startingBlock in apibara.config.ts sets startingBlock
to "2209820" which conflicts with the project baseline (should be 6767900) and
won't take effect when persistState is enabled; either restore startingBlock to
the baseline value (6767900) in apibara.config.ts or, if the rollback is
intentional, include a concise runbook that instructs operators to reset the
persisted checkpoint state referenced by persistState in
indexer/indexers/summit.indexer.ts (steps to stop the indexer, delete/clear the
checkpoint store, and restart) and add a brief comment in apibara.config.ts
noting the intentional deviation and linking to the runbook.
- Around line 7-8: The summitContractAddress value in apibara.config.ts is using
the wrong mainnet address; update the summitContractAddress entry to the
repo-standard mainnet value
"0x0455c73741519a2d661cad966913ee5ccb24596c518ad67dd1d189b49c15d4fa" (leave the
key name summitContractAddress unchanged) so the indexer targets the correct
stream, and while here confirm other contract address entries (e.g., Beast NFT,
Dojo World) match the provided mainnet addresses in the coding guidelines.
| summitContractAddress: | ||
| "0x01aa95ea66e7e01acf7dc3fda8be0d8661230c4c36b0169e2bab8ab4d6700dfc", |
There was a problem hiding this comment.
Summit contract address does not match the required mainnet address.
Line 8 uses a different Summit address than the repo-standard mainnet value, which can index the wrong event stream.
Suggested fix
- summitContractAddress:
- "0x01aa95ea66e7e01acf7dc3fda8be0d8661230c4c36b0169e2bab8ab4d6700dfc",
+ summitContractAddress:
+ "0x0455c73741519a2d661cad966913ee5ccb24596c518ad67dd1d189b49c15d4fa",As per coding guidelines: Use mainnet contract addresses: Summit 0x0455c73741519a2d661cad966913ee5ccb24596c518ad67dd1d189b49c15d4fa, Beast NFT 0x046da8955829adf2bda310099a0063451923f02e648cf25a1203aac6335cf0e4, Dojo World 0x02ef591697f0fd9adc0ba9dbe0ca04dabad80cf95f08ba02e435d9cb6698a28a.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| summitContractAddress: | |
| "0x01aa95ea66e7e01acf7dc3fda8be0d8661230c4c36b0169e2bab8ab4d6700dfc", | |
| summitContractAddress: | |
| "0x0455c73741519a2d661cad966913ee5ccb24596c518ad67dd1d189b49c15d4fa", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@indexer/apibara.config.ts` around lines 7 - 8, The summitContractAddress
value in apibara.config.ts is using the wrong mainnet address; update the
summitContractAddress entry to the repo-standard mainnet value
"0x0455c73741519a2d661cad966913ee5ccb24596c518ad67dd1d189b49c15d4fa" (leave the
key name summitContractAddress unchanged) so the indexer targets the correct
stream, and while here confirm other contract address entries (e.g., Beast NFT,
Dojo World) match the provided mainnet addresses in the coding guidelines.
| streamUrl: process.env.STREAM_URL, | ||
| // Starting block - use earliest block needed for Dojo events | ||
| startingBlock: "7077225", | ||
| startingBlock: "2209820", |
There was a problem hiding this comment.
startingBlock change needs explicit state-reset handling (and conflicts with baseline config rule).
Line 39 changes startingBlock to "2209820". Two problems:
- It diverges from the configured baseline expected for this file.
- With persisted checkpoint state enabled in
indexer/indexers/summit.indexer.ts(persistState: true), this rollback will not take effect on existing deployments unless indexer state/checkpoint is reset.
If this rollback is intentional, ship the reset/runbook with this PR; otherwise restore the baseline value.
As per coding guidelines: indexer/**/apibara.config.ts should configure runtime settings including starting block 6767900.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@indexer/apibara.config.ts` at line 39, The change to startingBlock in
apibara.config.ts sets startingBlock to "2209820" which conflicts with the
project baseline (should be 6767900) and won't take effect when persistState is
enabled; either restore startingBlock to the baseline value (6767900) in
apibara.config.ts or, if the rollback is intentional, include a concise runbook
that instructs operators to reset the persisted checkpoint state referenced by
persistState in indexer/indexers/summit.indexer.ts (steps to stop the indexer,
delete/clear the checkpoint store, and restart) and add a brief comment in
apibara.config.ts noting the intentional deviation and linking to the runbook.
The consumables table was defined in schema.ts but had no corresponding migration file, causing "relation does not exist" errors on fresh databases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Claude finished @starknetdev's task —— View job Claude Review - General Engineering ReviewTodo List
run=23193099896 attempt=1 sha=ea586b2b1d8901d31a4859e07d7f3ad7feab3cc5 scope=general Analysis ResultsThe git diff command targeting files outside the core app packages (contracts/, client/, indexer/, api/) returned no output. All files changed in this PR are within the excluded directories:
This PR contains:
Review FindingsNo issues found. Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO The changes in this PR are entirely within the client and indexer packages and do not affect repository tooling, CI/CD workflows, shared configuration, or other general engineering concerns that fall within the scope of this review. |
Codex Review - General Engineering ReviewReview process failed to complete. |
Codex Review - Indexer/API ReviewReview process failed to complete. |
|
Claude encountered an error —— View job Claude Review - Indexer/API ReviewTodo List
run=23193099896 attempt=1 sha=ea586b2b1d8901d31a4859e07d7f3ad7feab3cc5 scope=indexer-api Analysis ResultsThe git diff shows changes in two areas:
No changes in |
Prevents failure when table was already created manually. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Claude finished @starknetdev's task —— View job Claude Review - General Engineering Reviewrun=23193334610 attempt=1 sha=6d3ee9cb7145ce442b7268093ab35f4debd89698 scope=general Todo List
Analysis ResultsThe git diff command targeting files outside the core app packages (contracts/, client/, indexer/, api/) returned no output. All files changed in this PR are within the excluded directories:
This PR contains:
Review FindingsNo issues found. Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO The changes in this PR are entirely within the client and indexer packages and do not affect repository tooling, CI/CD workflows, shared configuration, or other general engineering concerns that fall within the scope of this review. |
Codex Review - General Engineering ReviewReview process failed to complete. |
|
Claude finished @starknetdev's task —— View job Claude Review - Indexer/API ReviewTodo List
run=23193334610 attempt=1 sha=6d3ee9cb7145ce442b7268093ab35f4debd89698 scope=indexer-api Analysis ResultsThe git diff shows changes in two areas:
No changes in Review Findings[CRITICAL] indexer/apibara.config.ts:8 - Summit contract address mismatch with canonical mainnet address [HIGH] indexer/apibara.config.ts:39 - Starting block changed without checkpoint reset strategy [MEDIUM] indexer/apibara.config.ts:23-35 - Consumable token addresses mismatch with canonical addresses
Positive Observations
Summary: 1 CRITICAL, 1 HIGH, 1 MEDIUM, 0 LOW, 0 INFO The critical issue with the wrong Summit contract address must be fixed immediately as it would cause complete indexer failure. The starting block rollback needs either reversion or proper state reset documentation. |
Codex Review - Indexer/API ReviewReview process failed to complete. |
1 participant
Summary
summit-production-69edtosummit-api-production-2Railway deploymentTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Chores