[codex] add beast appearance filters

[loothero]

Summary

• adds Animated, Shiny, and Animated + Shiny appearance filtering to the Beast upgrade selector
• extends /beasts/all with shiny and animated query filters so All Beasts pagination remains server-correct

Validation

• cd client && pnpm lint
• cd client && pnpm build
• cd api && pnpm exec tsc --noEmit
• cd api && pnpm build

Notes

• No DB or indexer migration is required because shiny and animated already exist on the beasts table and API response.
• No client-side filtering shortcut is used for All Beasts; correctness depends on the server-paginated API applying the filters.
• Client API/WS URLs remain pointed at the next branch services; after merge, the next API service should include these route changes.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
summit	Ready	Preview, Comment	Apr 26, 2026 4:26pm

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 447f1f80-d15c-471c-84de-d7ae841a822c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/beast-appearance-filters

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[railway-app]

🚅 Deployed to the summit-pr-139 environment in Summit

Service	Status	Web	Updated (UTC)
summit-api	✅ Success (View Logs)	Web	Apr 26, 2026 at 4:06 pm

1 service not affected by this PR

• summit-indexer

[claude]

Claude finished @loothero's task —— View job

---

Claude Review - General Engineering Review

Todo List:

• Run git diff to examine changes outside core app packages
• Analyze any CI/CD, tooling, or config changes for issues
• Format and post review findings

run=24960446046 attempt=1 sha=657cb143396ef82e2fbcfedb0b3f59c286499712 scope=general

Review Results

No issues found.

The git diff command targeting files outside the core app packages (contracts/, client/, indexer/, api/) returned no output, indicating that this PR only contains changes within the core application directories. All modifications are contained within the API and client packages as described in the PR summary.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

---

[github-actions]

Codex Review - General Engineering Review

Review process failed to complete.

[claude]

Claude finished @loothero's task —— View job

---

Claude Review - Indexer/API Review

run=24960446046 attempt=1 sha=657cb143396ef82e2fbcfedb0b3f59c286499712 scope=indexer-api

Review Tasks

• Run git diff to see scoped indexer/API changes
• Analyze API route changes for filtering logic
• Review data correctness and query efficiency
• Check schema consistency claims
• Validate migration requirement assessment
• Post comprehensive review findings

Findings

[LOW] api/src/index.ts:153-154 - Missing database indexes for shiny/animated filters
Impact: New shiny and animated query filters will perform full table scans instead of using indexes, degrading query performance as the beasts table grows.
Fix: Add indexes to the beasts table schema:

index("beasts_shiny_idx").on(table.shiny),
index("beasts_animated_idx").on(table.animated),

[INFO] api/src/ws/subscriptions.ts:195-264 - Improved dead client cleanup logic
Impact: Positive change - better handles WebSocket client cleanup and prevents memory leaks from dead connections.
Fix: No action needed, this is an improvement.

[INFO] api/src/index.ts:131-132,143-144,153-154 - Consistent query parameter handling
Impact: API correctly handles new shiny and animated query parameters with proper integer parsing using parseInt(shiny, 10) and parseInt(animated, 10).
Fix: No action needed, implementation is correct.

Schema Verification

✅ Migration claim verified: The shiny and animated columns already exist in the beasts table schema (lines 318-319 in /indexer/src/lib/schema.ts) as smallint fields. No migration is required.

✅ Data flow verified: The API response already includes shiny and animated fields in the response mapping (lines 236-237), confirming end-to-end data availability.

✅ Query safety verified: All new filter conditions use parameterized queries with proper type casting, preventing SQL injection.

Summary

0 CRITICAL, 0 HIGH, 0 MEDIUM, 1 LOW, 2 INFO

The changes are functionally correct and safe. The missing indexes for shiny and animated filters represent the only actionable issue - while the queries will work, they may perform poorly on larger datasets without proper indexing. The WebSocket improvements and consistent parameter handling are positive changes.

---

[github-actions]

Codex Review - Indexer/API Review

Review process failed to complete.

[codecov]

Codecov Report

❌ Patch coverage is 3.50877% with 55 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
client/src/components/dialogs/BeastDexModal.tsx	3.92%	49 Missing ⚠️
api/src/index.ts	0.00%	4 Missing ⚠️
client/src/api/summitApi.ts	0.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

[claude]

Claude finished @loothero's task —— View job

---

Claude Review - General Engineering Review

Todo List:

• Run git diff to examine changes outside core app packages
• Analyze any CI/CD, tooling, or config changes for issues
• Format and post review findings

run=24960531810 attempt=1 sha=36bcb267499e2cce6ee5249e8840ec6c18381d4f scope=general

Review Results

No issues found.

The git diff command targeting files outside the core app packages (contracts/, client/, indexer/, api/) returned no output, indicating that this PR only contains changes within the core application directories. All modifications are contained within the API and client packages as described in the PR summary.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

[github-actions]

Codex Review - General Engineering Review

Review process failed to complete.

[claude]

Claude finished @loothero's task —— View job

---

Claude Review - Indexer/API Review

run=24960531810 attempt=1 sha=36bcb267499e2cce6ee5249e8840ec6c18381d4f scope=indexer-api

Todo List:

• Run git diff to examine changes in indexer/ and api/ directories
• Analyze API route changes for filtering logic
• Review data correctness and query efficiency
• Check schema consistency claims
• Validate migration requirement assessment
• Format and post review findings

Findings

[LOW] api/src/index.ts:153-154 - Missing database indexes for shiny/animated filters
Impact: New shiny and animated query filters will perform full table scans instead of using indexes, degrading query performance as the beasts table grows.
Fix: Add indexes to the beasts table schema:

index("beasts_shiny_idx").on(table.shiny),
index("beasts_animated_idx").on(table.animated),

[INFO] api/src/ws/subscriptions.ts:195-264 - Improved dead client cleanup logic
Impact: Positive change - better handles WebSocket client cleanup and prevents memory leaks from dead connections.
Fix: No action needed, this is an improvement.

[INFO] api/src/index.ts:131-132,143-144,153-154 - Consistent query parameter handling
Impact: API correctly handles new shiny and animated query parameters with proper integer parsing using parseInt(shiny, 10) and parseInt(animated, 10).
Fix: No action needed, implementation is correct.

Schema Verification

✅ Migration claim verified: The shiny and animated columns already exist in the beasts table schema (lines 318-319 in /indexer/src/lib/schema.ts) as smallint fields. No migration is required.

✅ Data flow verified: The API response already includes shiny and animated fields in the response mapping (lines 236-237), confirming end-to-end data availability.

✅ Query safety verified: All new filter conditions use parameterized queries with proper type casting, preventing SQL injection.

Summary

0 CRITICAL, 0 HIGH, 0 MEDIUM, 1 LOW, 2 INFO

The changes are functionally correct and safe. The missing indexes for shiny and animated filters represent the only actionable issue - while the queries will work, they may perform poorly on larger datasets without proper indexing. The WebSocket improvements and consistent parameter handling are positive changes.

---

[github-actions]

Codex Review - Indexer/API Review

Review process failed to complete.

[gemini-code-assist]

Code Review

This pull request introduces filtering by 'shiny' and 'animated' traits for the /beasts/all endpoint, updating the API documentation, backend logic, and frontend components accordingly. It also enhances the SubscriptionHub with more robust WebSocket client management, including dead client detection and cleanup during broadcasts. Additionally, the PR includes various code cleanups such as removing unused imports, variables, and ESLint disable comments, while also improving test coverage for the ActionBar and SubscriptionHub. I have no feedback to provide.

[claude]

Claude finished @loothero's task —— View job

---

Claude Review - General Engineering Review

run=24960598857 attempt=1 sha=657cb143396ef82e2fbcfedb0b3f59c286499712 scope=general

Todo List:

• Run git diff to examine changes outside core app packages
• Analyze any CI/CD, tooling, or config changes for issues
• Format and post review findings

Review Results

No issues found.

The git diff command targeting files outside the core app packages (contracts/, client/, indexer/, api/) returned no output, indicating that this PR only contains changes within the core application directories. All modifications are contained within the API and client packages as described in the PR summary.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

---

[github-actions]

Codex Review - General Engineering Review

Review process failed to complete.

[claude]

Claude finished @loothero's task —— View job

---

Claude Review - Indexer/API Review

run=24960598857 attempt=1 sha=657cb143396ef82e2fbcfedb0b3f59c286499712 scope=indexer-api

Todo List:

• Run git diff to examine changes in indexer/ and api/ directories
• Analyze API route changes for filtering logic
• Review data correctness and query efficiency
• Check schema consistency claims
• Validate migration requirement assessment
• Format and post review findings

Findings

[LOW] api/src/index.ts:153-154 - Missing database indexes for shiny/animated filters
Impact: New shiny and animated query filters will perform full table scans instead of using indexes, degrading query performance as the beasts table grows.
Fix: Add indexes to the beasts table schema:

index("beasts_shiny_idx").on(table.shiny),
index("beasts_animated_idx").on(table.animated),

[INFO] api/src/ws/subscriptions.ts:195-264 - Improved dead client cleanup logic
Impact: Positive change - better handles WebSocket client cleanup and prevents memory leaks from dead connections.
Fix: No action needed, this is an improvement.

[INFO] api/src/index.ts:131-132,143-144,153-154 - Consistent query parameter handling
Impact: API correctly handles new shiny and animated query parameters with proper integer parsing using parseInt(shiny, 10) and parseInt(animated, 10).
Fix: No action needed, implementation is correct.

Schema Verification

✅ Migration claim verified: The shiny and animated columns already exist in the beasts table schema (lines 318-319 in /indexer/src/lib/schema.ts) as smallint fields. No migration is required.

✅ Data flow verified: The API response already includes shiny and animated fields in the response mapping (lines 236-237), confirming end-to-end data availability.

✅ Query safety verified: All new filter conditions use parameterized queries with proper type casting, preventing SQL injection.

Summary

0 CRITICAL, 0 HIGH, 0 MEDIUM, 1 LOW, 2 INFO

The changes are functionally correct and safe. The missing indexes for shiny and animated filters represent the only actionable issue - while the queries will work, they may perform poorly on larger datasets without proper indexing. The WebSocket improvements and consistent parameter handling are positive changes.

---

[github-actions]

Codex Review - Indexer/API Review

Review process failed to complete.

[claude]

Claude finished @loothero's task —— View job

---

Claude Review - General Engineering Review

run=24960634987 attempt=1 sha=64ab768a003ee7329fea5522b8ceb93630d1a9e1 scope=general

Todo List:

• Run git diff to examine changes outside core app packages
• Analyze any CI/CD, tooling, or config changes for issues
• Format and post review findings

Review Results

No issues found.

The git diff command targeting files outside the core app packages (contracts/, client/, indexer/, api/) returned no output, indicating that this PR only contains changes within the core application directories. All modifications are contained within the API and client packages as described in the PR summary.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

---

[github-actions]

Codex Review - General Engineering Review

Review process failed to complete.

[claude]

Claude finished @loothero's task —— View job

---

Claude Review - Indexer/API Review

run=24960634987 attempt=1 sha=64ab768a003ee7329fea5522b8ceb93630d1a9e1 scope=indexer-api

Todo List:

• Run git diff to examine changes in indexer/ and api/ directories
• Analyze API route changes for filtering logic
• Review data correctness and query efficiency
• Check schema consistency claims
• Validate migration requirement assessment
• Format and post review findings

Findings

[LOW] api/src/index.ts:153-154 - Missing database indexes for shiny/animated filters
Impact: New shiny and animated query filters will perform full table scans instead of using indexes, degrading query performance as the beasts table grows.
Fix: Add indexes to the beasts table schema:

index("beasts_shiny_idx").on(table.shiny),
index("beasts_animated_idx").on(table.animated),

[INFO] api/src/ws/subscriptions.ts:195-264 - Improved dead client cleanup logic
Impact: Positive change - better handles WebSocket client cleanup and prevents memory leaks from dead connections.
Fix: No action needed, this is an improvement.

[INFO] api/src/index.ts:131-132,143-144,153-154 - Consistent query parameter handling
Impact: API correctly handles new shiny and animated query parameters with proper integer parsing using parseInt(shiny, 10) and parseInt(animated, 10).
Fix: No action needed, implementation is correct.

Schema Verification

✅ Migration claim verified: The shiny and animated columns already exist in the beasts table schema (lines 318-319 in /indexer/src/lib/schema.ts) as smallint fields. No migration is required.

✅ Data flow verified: The API response already includes shiny and animated fields in the response mapping (lines 236-237), confirming end-to-end data availability.

✅ Query safety verified: All new filter conditions use parameterized queries with proper type casting, preventing SQL injection.

Summary

0 CRITICAL, 0 HIGH, 0 MEDIUM, 1 LOW, 2 INFO

The changes are functionally correct and safe. The missing indexes for shiny and animated filters represent the only actionable issue - while the queries will work, they may perform poorly on larger datasets without proper indexing. The WebSocket improvements and consistent parameter handling are positive changes.

---

[github-actions]

Codex Review - Indexer/API Review

Review process failed to complete.

[claude]

Claude finished @loothero's task —— View job

---

Claude Review - General Engineering Review

run=24961419912 attempt=1 sha=eab176814a0697ee9dc9a38f31920949d45d7a63 scope=general

Todo List:

• Run git diff to examine changes outside core app packages
• Analyze any CI/CD, tooling, or config changes for issues
• Format and post review findings

Review Results

No issues found.

The git diff command targeting files outside the core app packages (contracts/, client/, indexer/, api/) returned no output, indicating that this PR only contains changes within the core application directories. All modifications are contained within the API and client packages as described in the PR summary.

Summary: 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW, 0 INFO

[github-actions]

Codex Review - General Engineering Review

Review process failed to complete.

[claude]

Claude finished @loothero's task —— View job

---

Claude Review - Indexer/API Review

run=24961419912 attempt=1 sha=eab176814a0697ee9dc9a38f31920949d45d7a63 scope=indexer-api

Todo List:

• Run git diff to examine changes in indexer/ and api/ directories
• Analyze API route changes for filtering logic
• Review data correctness and query efficiency
• Check schema consistency claims
• Validate migration requirement assessment
• Format and post review findings

Findings

[LOW] api/src/index.ts:217-218 - Missing database indexes for shiny/animated filters
Impact: New shiny and animated query filters will perform full table scans instead of using indexes, degrading query performance as the beasts table grows.
Fix: Add indexes to the beasts table schema:

index("beasts_shiny_idx").on(table.shiny),
index("beasts_animated_idx").on(table.animated),

[INFO] api/src/index.ts:205-206,217-218 - Consistent query parameter handling
Impact: API correctly handles new shiny and animated query parameters with proper integer parsing using parseInt(shiny, 10) and parseInt(animated, 10).
Fix: No action needed, implementation is correct.

Schema Verification

✅ Migration claim verified: The shiny and animated columns already exist in the beasts table schema (lines 326-327 in /indexer/src/lib/schema.ts) as smallint fields. No migration is required.

✅ Data flow verified: The API response already includes shiny and animated fields in the response mapping (lines 361-362), confirming end-to-end data availability.

✅ Query safety verified: All new filter conditions use parameterized queries with proper type casting, preventing SQL injection.

✅ Cache bypass verified: The caching logic properly excludes the new filter parameters (lines 375-383), ensuring filtered queries bypass cache as expected.

Summary

0 CRITICAL, 0 HIGH, 0 MEDIUM, 1 LOW, 1 INFO

The changes are functionally correct and safe. The missing indexes for shiny and animated filters represent the only actionable issue - while the queries will work, they may perform poorly on larger datasets without proper indexing.

---

[github-actions]

Codex Review - Indexer/API Review

Review process failed to complete.

[claude]

Claude finished @loothero's task —— View job

---

Claude Review - React/Frontend Review

run=24961419912 attempt=1 sha=eab176814a0697ee9dc9a38f31920949d45d7a63 scope=client

Todo List:

• Run git diff to examine client changes
• Analyze React/TypeScript patterns and type safety
• Review query optimization and data flow
• Check UX reliability and error handling
• Validate domain logic consistency
• Format and post review findings

Findings

[INFO] client/src/api/summitApi.ts:56-57,177-178 - Well-structured API parameter extension
Impact: Positive change - cleanly extends the API interface and implementation for new filter parameters.
Fix: No action needed, implementation follows existing patterns correctly.

[INFO] client/src/components/dialogs/BeastDexModal.tsx:37-51 - Type-safe appearance filter logic
Impact: Positive change - uses proper TypeScript Pick utility type and explicit boolean coercion for reliable filtering.
Fix: No action needed, implementation is robust and type-safe.

[INFO] client/src/components/dialogs/BeastDexModal.tsx:53-56 - Clean query parameter mapping
Impact: Positive change - separates filter logic from query parameter generation with explicit undefined handling.
Fix: No action needed, follows good separation of concerns.

[LOW] client/src/components/dialogs/BeastDexModal.tsx:147-149 - Client-side filtering applied to "All Beasts" data
Impact: The client applies matchesAppearanceFilter to the "My Beasts" tab data, but since "All Beasts" tab uses server-side filtering via API parameters, there's an inconsistency in filtering strategy. While not incorrect, this could cause confusion if the filtering behavior differs between tabs.
Fix: Consider adding a comment to clarify that client-side filtering only applies to "My Beasts" tab, or refactor to make the distinction explicit.

[INFO] client/src/components/dialogs/BeastDexModal.tsx:177,202,245 - Proper useEffect dependency management
Impact: Positive change - correctly includes appearanceFilter in all relevant dependency arrays to ensure proper re-renders and data fetching.
Fix: No action needed, follows React hooks best practices.

[INFO] client/src/components/dialogs/BeastDexModal.tsx:218 - Spread operator for query parameters
Impact: Positive change - uses spread operator to cleanly include appearance query parameters only when needed.
Fix: No action needed, clean and readable implementation.

Summary

0 CRITICAL, 0 HIGH, 0 MEDIUM, 1 LOW, 5 INFO

The changes are well-implemented with proper TypeScript typing, React patterns, and error handling. The main observation is a minor inconsistency in filtering strategy between tabs (client-side for "My Beasts", server-side for "All Beasts"), but this appears to be intentional based on the PR description and doesn't affect functionality.

---

[github-actions]

Codex Review - React/Frontend Review

Review process failed to complete.