[proxysql-cluster] Change suggestion to work more as normal charts#3
Open
tokheim wants to merge 7 commits intoProxySQL:masterfrom
Open
[proxysql-cluster] Change suggestion to work more as normal charts#3tokheim wants to merge 7 commits intoProxySQL:masterfrom
tokheim wants to merge 7 commits intoProxySQL:masterfrom
Conversation
added 7 commits
March 15, 2022 20:32
…g sidecar Signed-off-by: Asmund Tokheim <tokheim@outlook.com>
Signed-off-by: Asmund Tokheim <tokheim@outlook.com>
Signed-off-by: Asmund Tokheim <tokheim@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I had a need for testing proxysql-cluster, but ended up doing quite a lot of changes to the chart. I'm open to splitting the changes up if you want to cherry-pick things etc. To highlight the features
<chart>/fileswhich I believe can't be done after chart packagingThe github action for packaging the chart requires all charts to be placed in a
/helmfolder, see helm/chart-releaser-action#78. To test the chart you can use