[codex] Support TCPViewer session export and import#61
Draft
NghiaTranUIT wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.tcpviewsessionas a ZIP-backed TCPViewer session format with readable JSON sidecars, an internalcapture.pcapng, de-duplicated client records, annotations, document-local state, and packaged client icons.The import path now handles malformed per-flow records gracefully: unsafe packages still fail at the package boundary, but malformed packet rows are skipped, valid flows continue importing, and TCPViewer shows an alert with imported/skipped flow counts only when skipped flows are present.
What Changed
.tcpviewsessionpackages.capture.pcapngpackets bycaptureOrdinal, so skipped rows do not shift inspection/export onto the wrong packet.Validation
git diff --checkxcodebuild -project TCPViewer.xcodeproj -scheme TCPViewer build CODE_SIGNING_ALLOWED=NO TCPVIEWER_DEVELOPMENT_TEAM=ABCDE12345 TCPVIEWER_BUILD_KEY=local-buildxcodebuild test -project TCPViewer.xcodeproj -scheme TCPViewer -destination platform=macOS CODE_SIGNING_ALLOWED=NO TCPVIEWER_DEVELOPMENT_TEAM=ABCDE12345 TCPVIEWER_BUILD_KEY=local-buildThe exact default build/test commands still fail locally because this machine does not have a valid Apple Development identity for the SMJobBless requirement generation step:
Invalid Apple Development signing identity for SMJobBless requirements: Sign to Run Locally.Disclosure
This PR was substantially assisted by AI and reviewed through local build/test runs before publishing.