Skip to content

fix: Installation tests by pinning lm-eval extras. #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ParagEkbote wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

fix: Installation tests by pinning lm-eval extras. #585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,8 @@ dependencies = [
vllm = [
"vllm>=0.16.0",
"ray",
"nvidia-cudnn-frontend; sys_platform == 'linux'",
Copy link
Copy Markdown
Member

@begumcig begumcig Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused, why did we change the vllm extras, for fixing the lm-eval problem?

Copy link
Copy Markdown
Contributor Author

@ParagEkbote ParagEkbote Apr 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, as you can view in the failing jobs, there are a couple of missing deps which are not installed during the installation test, which may cause the test to fail. Attaching some images for more context:

Image 1:
image

Image 2:
image

So, I am a bit uncertain if the deps should be a part of vllm or lm-eval dependency grouping since these are cuda driver packages which are generally pulled for vllm. I'd be happy to iterate to change them for lm-eval dependency grouping.

"nvidia-cutlass-dsl-libs-base; sys_platform == 'linux'",
]
stable-fast = [
"xformers>=0.0.30",
Expand Down
Loading