A suggestion for some minor comment and naming changes.#33
Merged
Conversation
Rename function "write_coord" to "write_float" and change the doc comments to reflect its purpose. We also rename function " " to "write_newline" keeping the 'write_' prefix for these functions consistent. Also some small changes for other comments.
Owner
|
Agree. This will depend on #31 so we can see were that lands (needs a bit of work) before doing this. |
Contributor
Author
|
Oh golly! (that PR adds 3908 lines and removes 554). |
Owner
|
Haha. Yea it needs to be split up and if you see my last comment I outline some stuff for them to consider. In the meantime, I've been squashing bugs and adding features on dev so there will then also need to be some merge conflicts resolved 😅 but I can sort that out when the time comes. |
Psy-Fer
added a commit
that referenced
this pull request
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename function "write_coord" to "write_float" and change the doc comments to reflect its purpose.
We also rename function "push_nl " to "write_newline" keeping the 'write_' prefix for these functions consistent.
Also some small changes for other comments.