Skip to content

use hash_map::entry get and update #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nkysg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use hash_map::entry get and update #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions qed-doge-data-link/src/block_cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ substantial portions of the software:
with contributions from Carter Feldman (https://x.com/cmpeq)."
*/

use std::collections::HashMap;
use std::collections::{HashMap, hash_map::Entry};

use doge_light_client::core_data::QDogeBlock;
use serde::{Deserialize, Serialize};
Expand Down Expand Up @@ -52,12 +52,16 @@ impl BlockFetcher {
}
}
pub fn get_block(&mut self, height: u32) -> anyhow::Result<QDogeBlock> {
if let Some(block) = self.store.get(&height) {
return Ok(block.clone());
match self.store.entry(height) {
Entry::Occupied(entry) => {
return Ok(entry.get().clone());
}
Entry::Vacant(entry) => {
let block = self.client.get_qdoge_block(height as u32)?;
entry.insert(block.clone());
return Ok(block);
}
}
let block = self.client.get_qdoge_block(height as u32)?;
self.store.insert(height, block.clone());
Ok(block)
}

pub fn get_blocks(&mut self, heights: &[u32]) -> anyhow::Result<Vec<QDogeBlock>> {
Expand Down